From owner-svn-src-all@FreeBSD.ORG Sat Jan 2 09:50:20 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 349F0106568B; Sat, 2 Jan 2010 09:50:20 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 19C788FC16; Sat, 2 Jan 2010 09:50:20 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o029oJxw004116; Sat, 2 Jan 2010 09:50:20 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o029oJVx004089; Sat, 2 Jan 2010 09:50:19 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <201001020950.o029oJVx004089@svn.freebsd.org> From: Ed Schouten Date: Sat, 2 Jan 2010 09:50:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r201380 - in head/libexec: . atrun bootpd bootpd/tools fingerd getty mail.local mknetid pppoed rbootd revnetgroup rpc.rquotad rpc.rstatd rpc.rusersd rpc.rwalld rpc.sprayd rshd rtld-elf ... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2010 09:50:20 -0000 Author: ed Date: Sat Jan 2 09:50:19 2010 New Revision: 201380 URL: http://svn.freebsd.org/changeset/base/201380 Log: Make WARNS=6 the default for libexec/. Just like bin/ and sbin/, I think setting WARNS to the highest value possible will make it more attractive for people to fix warnings. - The WARNS variable is set in the Makefile in the directory of the application itself, making it more likely that it will be removed out of curiosity to see what happens. - New applications will most likely build with WARNS=6 out of the box, because the author would more likely fix the warnings during development than lower WARNS. Unfortunately almost all apps in libexec require a lowered value of WARNS. Modified: head/libexec/Makefile.inc head/libexec/atrun/Makefile head/libexec/bootpd/Makefile head/libexec/bootpd/Makefile.inc head/libexec/bootpd/tools/Makefile.inc head/libexec/fingerd/Makefile head/libexec/getty/Makefile head/libexec/mail.local/Makefile head/libexec/mknetid/Makefile head/libexec/pppoed/Makefile head/libexec/rbootd/Makefile head/libexec/revnetgroup/Makefile head/libexec/rpc.rquotad/Makefile head/libexec/rpc.rstatd/Makefile head/libexec/rpc.rusersd/Makefile head/libexec/rpc.rwalld/Makefile head/libexec/rpc.sprayd/Makefile head/libexec/rshd/Makefile head/libexec/rtld-elf/Makefile head/libexec/smrsh/Makefile head/libexec/talkd/Makefile head/libexec/tcpd/Makefile head/libexec/tftp-proxy/Makefile head/libexec/tftpd/Makefile head/libexec/ulog-helper/Makefile head/libexec/ypxfr/Makefile Modified: head/libexec/Makefile.inc ============================================================================== --- head/libexec/Makefile.inc Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/Makefile.inc Sat Jan 2 09:50:19 2010 (r201380) @@ -2,4 +2,6 @@ # $FreeBSD$ BINDIR?= /usr/libexec + +WARNS?= 6 WFORMAT?= 1 Modified: head/libexec/atrun/Makefile ============================================================================== --- head/libexec/atrun/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/atrun/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -13,6 +13,8 @@ CLEANFILES= ${MAN} CFLAGS+=-I${MAINSRC} -I${.CURDIR} CFLAGS+=-DLOGIN_CAP -DPAM + +WARNS?= 2 WFORMAT=0 DPADD= ${LIBPAM} ${LIBUTIL} Modified: head/libexec/bootpd/Makefile ============================================================================== --- head/libexec/bootpd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/bootpd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,6 +5,8 @@ PROG= bootpd CFLAGS+= -DETC_ETHERS CFLAGS+= -DSYSLOG -DDEBUG -DVEND_CMU +WARNS?= 2 + SUBDIR= bootpgw tools SRCS= bootpd.c dovend.c readfile.c hash.c dumptab.c \ Modified: head/libexec/bootpd/Makefile.inc ============================================================================== --- head/libexec/bootpd/Makefile.inc Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/bootpd/Makefile.inc Sat Jan 2 09:50:19 2010 (r201380) @@ -1,3 +1,5 @@ # $FreeBSD$ BINDIR?= /usr/libexec + +WARNS?= 1 Modified: head/libexec/bootpd/tools/Makefile.inc ============================================================================== --- head/libexec/bootpd/tools/Makefile.inc Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/bootpd/tools/Makefile.inc Sat Jan 2 09:50:19 2010 (r201380) @@ -2,3 +2,5 @@ # $FreeBSD$ BINDIR= /usr/sbin + +WARNS?= 1 Modified: head/libexec/fingerd/Makefile ============================================================================== --- head/libexec/fingerd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/fingerd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,8 +5,8 @@ PROG= fingerd DPADD= ${LIBUTIL} LDADD= -lutil MAN= fingerd.8 -WARNS?= 2 +WARNS?= 2 WFORMAT=0 .include Modified: head/libexec/getty/Makefile ============================================================================== --- head/libexec/getty/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/getty/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -6,6 +6,8 @@ SRCS= main.c init.c subr.c chat.c DPADD= ${LIBUTIL} LDADD= -lutil MAN= gettytab.5 ttys.5 getty.8 + +WARNS?= 1 WFORMAT=0 .include Modified: head/libexec/mail.local/Makefile ============================================================================== --- head/libexec/mail.local/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/mail.local/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -8,6 +8,8 @@ PROG= mail.local SRCS= mail.local.c MAN= mail.local.8 CFLAGS+=-I${SENDMAIL_DIR}/include -I. + +WARNS?= 2 WFORMAT=0 LIBSMDIR= ${.OBJDIR}/../../lib/libsm Modified: head/libexec/mknetid/Makefile ============================================================================== --- head/libexec/mknetid/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/mknetid/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,4 +5,6 @@ SRCS= mknetid.c hash.c parse_group.c MAN= netid.5 mknetid.8 +WARNS?= 2 + .include Modified: head/libexec/pppoed/Makefile ============================================================================== --- head/libexec/pppoed/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/pppoed/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,6 +5,7 @@ DPADD= ${LIBNETGRAPH} LDADD= -lnetgraph MAN= pppoed.8 +WARNS?= 1 WFORMAT=0 .include Modified: head/libexec/rbootd/Makefile ============================================================================== --- head/libexec/rbootd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rbootd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,6 +5,7 @@ PROG= rbootd SRCS= bpf.c conf.c parseconf.c rbootd.c rmpproto.c utils.c MAN= rbootd.8 +WARNS?= 1 WFORMAT=0 .include Modified: head/libexec/revnetgroup/Makefile ============================================================================== --- head/libexec/revnetgroup/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/revnetgroup/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,4 +5,6 @@ SRCS= revnetgroup.c hash.c parse_netgrou MAN= revnetgroup.8 +WARNS?= 2 + .include Modified: head/libexec/rpc.rquotad/Makefile ============================================================================== --- head/libexec/rpc.rquotad/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rpc.rquotad/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -4,8 +4,6 @@ PROG = rpc.rquotad SRCS = rquotad.c MAN = rpc.rquotad.8 -WARNS ?= 6 - DPADD= ${LIBRPCSVC} LDADD= -lrpcsvc Modified: head/libexec/rpc.rstatd/Makefile ============================================================================== --- head/libexec/rpc.rstatd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rpc.rstatd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -7,4 +7,6 @@ MAN = rpc.rstatd.8 DPADD= ${LIBRPCSVC} ${LIBUTIL} ${LIBDEVSTAT} LDADD= -lrpcsvc -lutil -ldevstat +WARNS?= 1 + .include Modified: head/libexec/rpc.rusersd/Makefile ============================================================================== --- head/libexec/rpc.rusersd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rpc.rusersd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -4,8 +4,6 @@ PROG = rpc.rusersd SRCS = rusersd.c rusers_proc.c MAN = rpc.rusersd.8 -WARNS?= 6 - DPADD= ${LIBRPCSVC} ${LIBULOG} ${LIBUTIL} LDADD= -lrpcsvc -lulog -lutil @@ -14,5 +12,4 @@ LDADD= -lrpcsvc -lulog -lutil #LDADD+= -L/usr/X11R6/lib -lXext -lX11 #.endif - .include Modified: head/libexec/rpc.rwalld/Makefile ============================================================================== --- head/libexec/rpc.rwalld/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rpc.rwalld/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -7,4 +7,6 @@ MAN = rpc.rwalld.8 DPADD= ${LIBUTIL} LDADD= -lutil +WARNS?= 2 + .include Modified: head/libexec/rpc.sprayd/Makefile ============================================================================== --- head/libexec/rpc.sprayd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rpc.sprayd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -7,5 +7,6 @@ MAN = rpc.sprayd.8 DPADD= ${LIBRPCSVC} LDADD= -lrpcsvc -.include +WARNS?= 2 +.include Modified: head/libexec/rshd/Makefile ============================================================================== --- head/libexec/rshd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rshd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -4,6 +4,7 @@ PROG= rshd MAN= rshd.8 +WARNS?= 3 WFORMAT=0 DPADD= ${LIBUTIL} ${LIBPAM} Modified: head/libexec/rtld-elf/Makefile ============================================================================== --- head/libexec/rtld-elf/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/rtld-elf/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -12,6 +12,7 @@ CSTD?= gnu99 CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD CFLAGS+= -I${.CURDIR}/${MACHINE_ARCH} -I${.CURDIR} LDFLAGS+= -nostdlib -e .rtld_start +WARNS?= 2 INSTALLFLAGS= -C -b PRECIOUSPROG= BINDIR= /libexec Modified: head/libexec/smrsh/Makefile ============================================================================== --- head/libexec/smrsh/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/smrsh/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -15,6 +15,8 @@ LIBSM= ${LIBSMDIR}/libsm.a DPADD= ${LIBSM} LDADD= ${LIBSM} +WARNS?= 2 + SRCS+= sm_os.h CLEANFILES+=sm_os.h Modified: head/libexec/talkd/Makefile ============================================================================== --- head/libexec/talkd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/talkd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -7,7 +7,6 @@ SRCS= talkd.c announce.c process.c table MAN= talkd.8 CFLAGS+=-I${.CURDIR}/../../usr.bin/wall -WARNS?= 6 DPADD= ${LIBULOG} LDADD= -lulog Modified: head/libexec/tcpd/Makefile ============================================================================== --- head/libexec/tcpd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/tcpd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -18,4 +18,6 @@ CFLAGS+=-DINET6 DPADD= ${LIBWRAP} LDADD= -lwrap +WARNS?= 1 + .include Modified: head/libexec/tftp-proxy/Makefile ============================================================================== --- head/libexec/tftp-proxy/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/tftp-proxy/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -6,4 +6,6 @@ PROG= tftp-proxy SRCS= tftp-proxy.c filter.c MAN= tftp-proxy.8 +WARNS?= 3 + .include Modified: head/libexec/tftpd/Makefile ============================================================================== --- head/libexec/tftpd/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/tftpd/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -5,7 +5,10 @@ PROG= tftpd SRCS= tftpd.c tftpsubs.c DPADD= ${LIBUTIL} LDADD= -lutil + +WARNS?= 1 WFORMAT=0 + MAN= tftpd.8 CFLAGS+=-I${.CURDIR}/../../usr.bin/tftp .PATH: ${.CURDIR}/../../usr.bin/tftp Modified: head/libexec/ulog-helper/Makefile ============================================================================== --- head/libexec/ulog-helper/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/ulog-helper/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -8,6 +8,4 @@ NO_MAN= DPADD= ${LIBULOG} LDADD= -lulog -WARNS?= 6 - .include Modified: head/libexec/ypxfr/Makefile ============================================================================== --- head/libexec/ypxfr/Makefile Sat Jan 2 09:45:59 2010 (r201379) +++ head/libexec/ypxfr/Makefile Sat Jan 2 09:50:19 2010 (r201380) @@ -12,7 +12,10 @@ GENSRCS=yp.h yp_clnt.c ypxfr_clnt.c MAN= ypxfr.8 CFLAGS+= -I. + +WARNS?= 2 WFORMAT=0 + DPADD= ${LIBRPCSVC} LDADD= -lrpcsvc