From owner-svn-src-all@freebsd.org Fri Jan 8 21:32:03 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2981DA68C9F; Fri, 8 Jan 2016 21:32:03 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 13E0212B2; Fri, 8 Jan 2016 21:32:02 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u08LW2OZ012178 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 8 Jan 2016 13:32:02 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u08LW2Q4012177; Fri, 8 Jan 2016 13:32:02 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 8 Jan 2016 13:32:02 -0800 From: Gleb Smirnoff To: NGie Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293439 - in head: lib/libc/sys sys/dev/ti sys/kern sys/sys usr.bin/netstat Message-ID: <20160108213202.GI1906@FreeBSD.org> References: <201601082034.u08KYvLv075281@repo.freebsd.org> <96B980EE-FD2F-490E-BA5E-4F23A67CEB18@gmail.com> <20160108211041.GG1906@FreeBSD.org> <88B48C42-DFEF-4CAE-973E-BDF2A408B4A3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <88B48C42-DFEF-4CAE-973E-BDF2A408B4A3@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 21:32:03 -0000 On Fri, Jan 08, 2016 at 01:22:45PM -0800, NGie Cooper wrote: N> > 1) The review requests were sent continuosly to arch@ during last 1.5 years. N> > N> > https://lists.freebsd.org/pipermail/freebsd-arch/2014-May/015385.html N> > N> > 2) Team of engineers at Netflix has a lot of code build on top of that code, N> > e.g. SSL_sendfile(). Of course, writing something on top assumes reviewing, N> > so assume it reviewed thoroughly by rrs@. Actually, here is list of people N> > who did some review of the code: emax@, rrs@, scottl@, gallatin@, imp@. N> > N> > 3) Do you have any particulars concerns with this change or those made recently N> > to sys/kern and sys/net*? N> N> I don’t as of right now, other than it’s really difficult to audit changes and assess risk if someone doesn’t have access to the CRs :(. N> N> Also… N> N> N> > An N> N> > explanation of why such behavior is beneficial compared to old one is N> N> > going to be too long for a commit message, so we will skip it here. N> N> This wasn’t really helpful. It would have been nice if there was a wiki page or some other reference used in this commit which would have described the where, why, and how behind this change a lot more. I'm writing status report on this right now. Also there is slideshare: http://www.slideshare.net/facepalmtarbz2/new-sendfile-in-english And there is even a paper, alas in Russian. -- Totus tuus, Glebius.