From owner-cvs-src@FreeBSD.ORG Tue Sep 14 06:43:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28EFC16A4CE; Tue, 14 Sep 2004 06:43:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26BFF43D41; Tue, 14 Sep 2004 06:43:47 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i8E6hlMI006033; Tue, 14 Sep 2004 06:43:47 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i8E6hlXx006032; Tue, 14 Sep 2004 06:43:47 GMT (envelope-from truckman) Message-Id: <200409140643.i8E6hlXx006032@repoman.freebsd.org> From: Don Lewis Date: Tue, 14 Sep 2004 06:43:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/dev/sound/pcm sndstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2004 06:43:47 -0000 truckman 2004-09-14 06:43:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/sound/pcm sndstat.c Log: MFC sndstat.c 1.18 > Convert sndstat_lock from a mutex to an sx lock. sndstat_read() > holds sndstat_lock across a call to uiomove(), which is not legal > to do with a mutex because of the possibility that the data transfer > could sleep because of a page fault. It is not possible to just > unlock the mutex for the uiomove() call without introducing another > locking mechanism to prevent the body of sndstat_read() from being > re-entered. Converting sndstat_lock to an sx lock is the least > complicated change. LOR: 030 Approved by: re (scottl) Revision Changes Path 1.17.2.1 +29 -26 src/sys/dev/sound/pcm/sndstat.c