From owner-svn-ports-head@freebsd.org Sat Dec 17 17:00:10 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02D53C85449; Sat, 17 Dec 2016 17:00:10 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B837B7C; Sat, 17 Dec 2016 17:00:09 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 517F8BDD72; Sat, 17 Dec 2016 18:00:07 +0100 (CET) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 17CCFBDD4C; Sat, 17 Dec 2016 18:00:07 +0100 (CET) Subject: Re: svn commit: r428763 - in head/audio/fluidsynth: . files To: Thomas Zander References: <201612171341.uBHDfWIF098306@repo.freebsd.org> <8e01a684-eef8-a3ab-1cea-757db5879feb@FreeBSD.org> Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: Date: Sat, 17 Dec 2016 18:00:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qEFBOQh6MFxs3JojIt18AW1Kth6Ct5TlK" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 17:00:10 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qEFBOQh6MFxs3JojIt18AW1Kth6Ct5TlK Content-Type: multipart/mixed; boundary="DsTCVB5jVOqkvaxe7M9ktD9OowFoFt9B6"; protected-headers="v1" From: Mathieu Arnold To: Thomas Zander Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r428763 - in head/audio/fluidsynth: . files References: <201612171341.uBHDfWIF098306@repo.freebsd.org> <8e01a684-eef8-a3ab-1cea-757db5879feb@FreeBSD.org> In-Reply-To: --DsTCVB5jVOqkvaxe7M9ktD9OowFoFt9B6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 17/12/2016 =C3=A0 17:38, Thomas Zander a =C3=A9crit : > On 17 December 2016 at 14:50, Mathieu Arnold wrote: >> Le 17/12/2016 =C3=A0 14:41, Thomas Zander a =C3=A9crit : >>> Modified: head/audio/fluidsynth/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/audio/fluidsynth/Makefile Sat Dec 17 13:26:05 2016 = (r428762) >>> +++ head/audio/fluidsynth/Makefile Sat Dec 17 13:41:32 2016 = (r428763) >>> @@ -13,7 +13,7 @@ COMMENT=3D Real-time software synthesizer >>> LICENSE=3D LGPL20 >>> LICENSE_FILE=3D ${WRKSRC}/COPYING >>> >>> -OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUD= IO SNDFILE >>> +OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUD= IO SNDFILE SNDIO >>> OPTIONS_DEFAULT=3D JACK >> This is missing a PORTREVISION bump. > Since when? The new SNDIO knob is disabled by default and the default > package remains unchanged. First, because, well, it is the rule[1]. You changed the options list, so the package can change, so it must be bumped. Second, because if I had built this port before you added the option, and I had sndio installed, it would be linked with it but there would not be a dependency recorded. But if I build it after this option is added, it is not liked with SNDIO any more. Which makes a different package, which is a big reason for bumping PORTREVISION. >>> +SNDIO_LIB_DEPENDS=3D libsndio.so:audio/sndio >>> +SNDIO_CMAKE_OFF=3D -Denable-sndio:BOOL=3DFALSE >> I guess this should probably be: >> >> SNDIO_CMAKE_BOOL=3D enable-sndio > At the moment, fluidsynth handles all CMAKE bool switches in the 'old' > fashion. We should update all of them, but I'd like to confirm that it > still builds. 1: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.htm= l#makefile-portrevision --=20 Mathieu Arnold --DsTCVB5jVOqkvaxe7M9ktD9OowFoFt9B6-- --qEFBOQh6MFxs3JojIt18AW1Kth6Ct5TlK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJYVW8WXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IN0MQALYBzfp2E4iLstoFxeBY1iuI oc8UUabh5uzztCp5OnMDqBSOusSi1s9evXANxsZahRr+s2BwH8bOIPU8qmnL4y3d 2f1LkE4dsaWrCW5/JU1k/0OMWF5k6dRuX1CMrEMeiq9vcgEvTLSMTW+lJ/dxjf2a a3h7iCKPzSRRKm0l1+Djs6horMLi6uHGfmDknpvJyGWMgwfMu6MNWdF3rqe9ji9G VtTo+kzFT+GgVTJuycsM+FtMgWnNzaVXAMpgLdwB6o65G3pp6WW5LbAA8ixNx7zL ePWpAW5/9j8/MHLwYmcmikVQ+3Bs+1fiML62Vagk0e/YRXGsDkQyjTx/B2FFG3Wy NBwlyBNH/oA7KcerF5iYiG7J9OiNAzGXSzggZyhgwuAqY/hYHE15fpMyNXLLqJIu UjeJOD2SqwtK+ghjm//uETi0L5L9wr6bgSpyTm/BhAw1hmmQJmX+RCCqMJxYPRz4 GJncou6VBpUkQtPp3E58ul8Gnj2cIofIAFzGSTLoiRJxk0/1Wqs2PUM1UNHeHsrD GA5eibgWP2hNDytOia7wDIHvsLA9rIxQlFETx1wngIV9P6mPJncMeAvL2B6PddFB IvSYntzJS5TgCFh1fkwFfdzXkM4Ke2rT+fmqnoK/aeMoAbgRNqRZSwA4I09kLNpb p+tjYEeVQMEX5leulY2W =Y1rp -----END PGP SIGNATURE----- --qEFBOQh6MFxs3JojIt18AW1Kth6Ct5TlK--