From owner-cvs-all@FreeBSD.ORG Sat Jun 16 07:47:25 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5279D16A468 for ; Sat, 16 Jun 2007 07:47:25 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0C98213C45E for ; Sat, 16 Jun 2007 07:47:24 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: by wa-out-1112.google.com with SMTP id j37so1484844waf for ; Sat, 16 Jun 2007 00:47:24 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=H6u9wK3fKAQz0v3/UwTAreGAJsz9gw7zrssOleGXRIpDIGpVa48Q7dMvJqSFDjYK2JRK7RcmNhCiOeFHZssD7/rBbzwAc+ozkCFj3uNMo3D6iHelz3taj9q6PqI0WYE7ScvgHK5Fc1GnAjtQ78lr2a8LVQ2nv/Oei8eDQGuB3NQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=dz/JZ06EylnZbTigoU3WxvCg0K+pn6QztRWkfIn8Pg5tx02HlGJqa/pHaQsjELt8IBKCV2Gk8irCroTPqVAlZAGhmndF4E4kHyhWQBUe81ukAGc5i/wjN/Dz8IAVzZkDjK6ZtOOolFrnZZHQnzo8JOmRWVMvFYBZyEzQLhcEcTs= Received: by 10.114.124.1 with SMTP id w1mr3894869wac.1181980044661; Sat, 16 Jun 2007 00:47:24 -0700 (PDT) Received: by 10.114.194.5 with HTTP; Sat, 16 Jun 2007 00:47:24 -0700 (PDT) Message-ID: Date: Sat, 16 Jun 2007 11:47:24 +0400 From: "Andrew Pantyukhin" Sender: infofarmer@gmail.com To: "Rong-En Fan" , cvs-all@freebsd.org, cvs-ports@freebsd.org, ports-committers@freebsd.org In-Reply-To: <20070616074134.GF29573@svm.csie.ntu.edu.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200706152057.l5FKv26c070603@repoman.freebsd.org> <20070615210224.3C6A116A5D1@hub.freebsd.org> <1181947632.52923.7.camel@ikaros.oook.cz> <20070616063243.GA9047@FreeBSD.org> <20070616074134.GF29573@svm.csie.ntu.edu.tw> X-Google-Sender-Auth: 34bde78d4d239aff Cc: Subject: Re: cvs commit: ports/graphics/tcm Makefile pkg-message ports/graphics/tcm/files patch-debian-gcc4 pkg-message.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2007 07:47:25 -0000 On 6/16/07, Rong-En Fan wrote: > On Sat, Jun 16, 2007 at 10:55:58AM +0400, Andrew Pantyukhin wrote: > > On 6/16/07, Alexey Dokuchaev wrote: > > > On Sat, Jun 16, 2007 at 10:23:09AM +0400, Andrew Pantyukhin wrote: > > > > On 6/16/07, Pav Lucistnik wrote: > > > > >Andrew Pantyukhin p????e v so 16. 06. 2007 v 01:20 +0400: > > > > > > > > > >> > -WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} > > > > >> > -PKGMESSAGE= ${WRKSRC}/pkg-message > > > > >> > -USE_MOTIF= yes > > > > >> > USE_BISON= yes > > > > >> > USE_GMAKE= yes > > > > >> > +USE_MOTIF= yes > > > > >> > + > > > > >> > +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} > > > > >> > +SUB_FILES+= pkg-message > > > > >> > > > > >> PKGMESSAGE defaults to PKGDIR/pkg-message. If we > > > > >> have it processed with SUB_FILES, it will end up > > > > >> in WRKDIR/pkg-message > > > > > > > > > >So? His usage of SUB_FILES is perfectly fine. > > > > > > > > What I can't seem to understand is why PKGMESSAGE is > > > > changing from PKGDIR/pkg-message to WRKDIR/pkg-message > > > > when SUB_FILES=pkg-message is defined. > > > > > > Probably because of this: > > > bpm, around line 5554: > > > > > > .for i in pkg-message pkg-install pkg-deinstall pkg-req > > > .if ${SUB_FILES:M${i}*}!="" > > > ${i:S/-//:U}= ${WRKDIR}/${SUB_FILES:M${i}*} > > > .endif > > > .endfor > > > > Hacky, but cool. Unfortunately it was never mentioned > > in CHANGES, nor even in commit message (*wink at krion > > and flz*). The only docs we have is ports/67151 and > > code. Not that it requires any decoding, but a quick > > IIRC, it's in Porter's Handbook No way, I checked the section three times this morning. Oh, wait... "For the files pkg-message, pkg-install, pkg-deinstall and pkg-reg, the corresponding Makefile variable is automatically set to point to the processed version." /me is rapidly developing blindness Sorry! (but we need to do something about the stats)