From owner-freebsd-acpi@FreeBSD.ORG Sun Jun 21 16:56:21 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 517901065672 for ; Sun, 21 Jun 2009 16:56:21 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-ew0-f212.google.com (mail-ew0-f212.google.com [209.85.219.212]) by mx1.freebsd.org (Postfix) with ESMTP id CE4EC8FC0A for ; Sun, 21 Jun 2009 16:56:20 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ewy8 with SMTP id 8so3229962ewy.43 for ; Sun, 21 Jun 2009 09:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=pn4AQHFMyammzATaxWTnGaK0fZ+FVYBNwX3eEXHRhrE=; b=KEspy/4qjf3mhzGDOOkXHvy7h4KMdYTNhT68wM3612RrKSmPAmgvlGY5e6pQA5gRpd 7iAfj6j2qjWI7Ob0yAHEM92DZy8bgrBN2CNQ2gQr7Uyp8otYWOsFrD7NsZqZ/otLuOaw hgkSeNmL+xxXJDdKOa32jn63hbTscTxqi2URg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=fYbBtMHPtdAIF//gRCSRleyM0/+hVpuB67q1dnKcj3hmkUifxra0XMCy74mPXhKkDi EjSHTL8jr3fE+vCEn7Dq/1XrT36GGfXAUUt67xRXHftDLKfAzDbwT4vbBlKS1NnlSm22 VG0LmXUBGdUzRu8y5GpChlSSRAD090ujwdGK8= Received: by 10.210.128.5 with SMTP id a5mr3580633ebd.85.1245603379747; Sun, 21 Jun 2009 09:56:19 -0700 (PDT) Received: from omega.lan (bl9-155-202.dsl.telepac.pt [85.242.155.202]) by mx.google.com with ESMTPS id 23sm3482398eya.49.2009.06.21.09.56.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 21 Jun 2009 09:56:19 -0700 (PDT) Sender: Rui Paulo Message-Id: From: Rui Paulo To: Michael In-Reply-To: <4A3E5F40.4040709@bindone.de> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Sun, 21 Jun 2009 17:56:17 +0100 References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> <4A3E5F40.4040709@bindone.de> X-Mailer: Apple Mail (2.935.3) Cc: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 16:56:21 -0000 On 21 Jun 2009, at 17:26, Michael wrote: > Rui Paulo wrote: >> On 21 Jun 2009, at 15:08, Rui Paulo wrote: >> >>> On 21 Jun 2009, at 12:20, Michael wrote: >>> >>>> Hello, >>>> >>>> I wrote two new acpi modules last year and finally found the time >>>> to fix >>>> them, add some missing features and write man pages. >>> >>> Michael, this is great work! I'll review and see if we can ship it >>> with 8.0! >> >> Michael, this looks good, but there are two style nits that we need >> to fix. >> * we should try not going over the 80 column mark >> * add a empty new line before every return >> >> If you could send me a new patch for 8.0 with these fixes, I'll >> commit >> it (unless someone else has objections). >> >> Regards, >> -- >> Rui Paulo >> > > Hi Rui, > > hmm style(9) doesn't say anything about columns or return statements > in > this context (maybe it should be updated?!?). I've been looking again at style(9) and seems like I'm misremembering something. Please ignore this request and sorry for the hassle. -- Rui Paulo