From owner-freebsd-current@freebsd.org Mon Oct 22 21:09:43 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37AB4FD6A5F for ; Mon, 22 Oct 2018 21:09:43 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from land.berklix.org (land.berklix.org [144.76.10.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "land.berklix.org", Issuer "land.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id ABBE073DDF; Mon, 22 Oct 2018 21:09:42 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p2E52CCDC.dip0.t-ipconnect.de [46.82.204.220]) (authenticated bits=0) by land.berklix.org (8.15.2/8.15.2) with ESMTPSA id w9ML9ZcM055720 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Oct 2018 21:09:39 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id w9ML9UfP027280; Mon, 22 Oct 2018 23:09:30 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id w9ML96bF050497; Mon, 22 Oct 2018 23:09:18 +0200 (CEST) (envelope-from jhs@berklix.com) Message-Id: <201810222109.w9ML96bF050497@fire.js.berklix.net> To: Stefan Esser cc: FreeBSD Current , =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= , Stefan Esser Subject: Re: careless commits disrupt From: "Julian H. Stacey" Organization: http://berklix.eu BSD Unix Linux Consultants, Munich Germany User-agent: EXMH on FreeBSD http://berklix.eu/free/ X-From: http://www.berklix.eu/~jhs/ In-reply-to: Your message "Fri, 12 Oct 2018 11:44:59 +0200." Date: Mon, 22 Oct 2018 23:09:06 +0200 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 21:09:43 -0000 Hi, Reference: > From: Stefan Esser > Date: Fri, 12 Oct 2018 11:44:59 +0200 Stefan Esser wrote: > Am 12.10.18 um 07:39 schrieb Dag-Erling Sm�rgrav: > > Julian H. Stacey writes: > >> Stefan Esser writes: > >>> You should also delete old files: > >>> > >>> cd /usr/src > >>> make delete-old > >>> make delete-old-libs > >> I just ran that. It deleted lots of stuff. & I'd only run it 2 days ago. > >> I should have run it just before buildworld though. > >> It's not suggested in the top of > >> https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html > >> just at base of page. > > > > That's because you should *never* run delete-old or delete-old-libs from > > a source tree that is newer than your installed system. It may delete > > files which have been obsoleted by changes you haven't yet built and > > installed, to the point where you may be unable to build and install > > those changes. In this particular case, it will, at the very least, > > break ssh and svn / svnlite. > > Yes, sorry, running make delete-old-libs before buildworld is no good > idea, unless the old libraries have been copied to /usr/lib/compat before. > > > The advice to run "make delete-old-libs" came from the following message > from Glen Barber: > > https://lists.freebsd.org/pipermail/freebsd-current/2018-October/071581.html > > But the advice was not to delete old files before make buildworld, but only > before starting the required port upgrades ... > > > I might have mentioned, that I always preserve old shared libraries in > /usr/lib/compat before running "make delete-old-libs". Good idea, are you doing that manually, or do you have a patch to share ? > This allows to run > old binaries, but prevents linking of new binaries against these libraries > (should not matter for make buildworld, but for building ports, which I do > at in the same script that invokes buildworld for critical kernel modules > that are to be built from ports). > > No binary or library should reference a library whose path contains > /compat/ after all upgrades have been performed, obviously ... > > Regards, STefan Cheers, Julian -- Julian Stacey, Computer Consultant, Systems Engineer, BSD Linux Unix, Munich. Brexit referendum stole 3,700,000 Brits votes abroad, inc. 700,000 in EU. Campaign lies, criminal funding, economy & pound down. Time for an honest ref. http://exitbrexit.uk https://www.peoples-vote.uk/petition https://eci.ec.europa.eu/002/public/#/initiative