From owner-freebsd-audit  Sun Feb  9  7:44:18 2003
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6AC8137B401; Sun,  9 Feb 2003 07:44:17 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 424CF43F75; Sun,  9 Feb 2003 07:44:16 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id CAA02615;
	Mon, 10 Feb 2003 02:44:05 +1100
Date: Mon, 10 Feb 2003 02:44:08 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: Sean Chittenden <seanc@FreeBSD.ORG>, <audit@FreeBSD.ORG>
Subject: Re: WARNS = 2, sbin/ping...
In-Reply-To: <xzpof5l60od.fsf@flood.ping.uio.no>
Message-ID: <20030210024135.N997-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Sun, 9 Feb 2003, Dag-Erling Smorgrav wrote:

> Sean Chittenden <seanc@FreeBSD.org> writes:
> > Speaking of WARNS2, here's a patch that bumps ping(8) to WARNS2.  Once
> > upon a tie it used to be WARNS5, but the patch has rotted some.  The
> > biggie in this one was collisions with sin(3) and sockaddr_in variable
> > sin.
>
> That's a compiler bug (unless <math.h> is in scope).  The correct
> solution is not to rename the variable, but to add -fno-builtin to
> CFLAGS globally, and fix those parts of the tree that break due to
> missing includes.  Who knows, we might even uncover libc bugs that
> have been hitherto been masked by the compiler.

Script started on Mon Feb 10 02:42:09 2003
ttyp0:bde@besplex:/tmp> grep math.h /usr/src/sbin/ping/ping.c
#include <math.h>
ttyp0:bde@besplex:/tmp> exit

Script done on Mon Feb 10 02:42:22 2003

[wollman added this include long ago to support printing standard deviations.]

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message