From owner-cvs-src@FreeBSD.ORG  Wed Apr 26 16:06:12 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4934516A402;
	Wed, 26 Apr 2006 16:06:12 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DF93343D46;
	Wed, 26 Apr 2006 16:06:11 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3QG4bgU038425;
	Wed, 26 Apr 2006 10:04:38 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Wed, 26 Apr 2006 10:04:46 -0600 (MDT)
Message-Id: <20060426.100446.128616681.imp@bsdimp.com>
To: mj@feral.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20060425165324.M64286@ns1.feral.com>
References: <444E7BFE.4040800@samsco.org>
	<20060425.173236.74726638.imp@bsdimp.com>
	<20060425165324.M64286@ns1.feral.com>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, scottl@samsco.org, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, jhb@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Apr 2006 16:06:12 -0000

In message: <20060425165324.M64286@ns1.feral.com>
            Matthew Jacob <mj@feral.com> writes:
: 
: > The problem is that PAE's bus_size_t is a 32-bit quantity, when it
: > should be a 64-bit quantity:
: >
: > #ifdef PAE
: > typedef uint64_t bus_addr_t;
: > #else
: > typedef uint32_t bus_addr_t;
: > #endif
: > typedef uint32_t bus_size_t;
: >
: > For bus addresses, we should use bus_addr_t, of course, but the above
: > is wrong.  I don't have a PAE machine, or I'd commit my local changes
: > that fix this...
: >
: 
: Why do you believe that it should be a 64 bit quantity under PAE?
: 
: Strictly speaking, I don't believe it is. PAE allows you to *address* 
: 36 physical address bits of memory using Dual Address cycles, but the 
: underlying bus is still a 32 bit bus.

Because it expands the address space > 32 bits.

Warner