From owner-freebsd-current@freebsd.org Thu Jul 25 18:35:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C3E2AB2C7 for ; Thu, 25 Jul 2019 18:35:13 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 474E98F53C for ; Thu, 25 Jul 2019 18:35:13 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1564079706; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=AZpGmHGWxhjQ3zQOrGSHbo9R9dTMFgpd1whLR+vMB/twtt9JD97ZJMUnI6ebSX81w8wl2G83B9BJL qnWCvKv083cVm/Ib0wTAmhmKtRMZOWMdKkQm4kGPxJGkYOhcWvKHFyzmUCY/pKnYpTWQa+dHqIGubE tgBOAY1eyemzTjN4BfsgSsb7N1RDpUQupOG/chRPKzaFxPmzj/N3Mj4qSkYZ0sA36FxJFTHzB/pTiw xEmOnNHuwYruI/w5BPE+emLHnHd9RWbD+UwR8u74Wb+cmTX1m8/2OigNf2KkUATsy9VnO6n/0CraZG A3dfGHOF3zH3bwzlrBf5XKgb7+SvAeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=/pKkpqJ4II0kKtr7Q3mjw7qpk0dbLkr5+/7Cfcoi/4M=; b=VYk02mREDCNxFV7lgLMjeVuBwa0V1GKt/yPYxI8InJz6ns1Y8FXLJ3g1Q+SqRKl6f/2MhgGiY7lGP XBQaIJ/UrfjKAYaz2hjqlBziXSBAHnzIDEFNo3oiGhzEa/psjchnr3RL+q+R9scQHlDqv0MpRJ/tK8 QwxIJRj/OxttWHkqnQJVqLczPVt3zMz2zz5AdIwIKXVVNhyR+x/rjynieAg+kYt9jpgQT+ADGf1+0C x2hA1EC00iE3jK2L4GBln1LYGbaOYvm7xbsKBaXsT+L5GI65/FXlNCkDpyPv9lncVscK4WLq8zgdps Ula38wVsmRc37y1CPqPskFvZExxDB4A== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=/pKkpqJ4II0kKtr7Q3mjw7qpk0dbLkr5+/7Cfcoi/4M=; b=YnUO3qZMuUvZknset3x2NRMX5cty7vJNnZJ4C9UGCsnNpm8sjEW0s22YdtbSDJj6/Rc0l1wiWBPmW BPschFTDr4vVqvaZHkSIELPJC70s1H8Cb3G33mbIz5BWS01c3RlSJKGEE68EuP7ZJGsAaqjRUSohmY uBirM1HiWOu5JFYYqQbD0PBsVHBGjePXL3a7CslnUJ4K6U4ZtgkopCLh7eD/2K5MGsACppASRth2/A 73VXKJ0qWksyhNCev+bPZ5idlNPZ0DH/zo4vO1w+Je5aYOlb9QjXurPcT1aW0ZjccJHchunz9G2JLA +9XbDt0Hquwmt8tADJ38g3PoXX+76Ww== X-MHO-RoutePath: aGlwcGll X-MHO-User: eb032f4a-af0a-11e9-b679-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id eb032f4a-af0a-11e9-b679-cdd75d6ce7a8; Thu, 25 Jul 2019 18:35:04 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x6PIZ3mo073944; Thu, 25 Jul 2019 12:35:03 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build From: Ian Lepore To: Larry Rosenman , Alan Somers Cc: Freebsd current Date: Thu, 25 Jul 2019 12:35:03 -0600 In-Reply-To: References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 474E98F53C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 18:35:13 -0000 On Thu, 2019-07-25 at 13:13 -0500, Larry Rosenman wrote: > On 07/25/2019 1:10 pm, Alan Somers wrote: > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman > > wrote: > > > > > > Um.... Who broke this? > > > > > > /usr/src/sys/sys/refcount.h:65:12: error: use of undeclared > > > identifier > > > 'false' > > > return (false); > > > ^ > > > [...] > > > > > "svn blame" suggests r350199 by kib. However, refcount.h should > > only > > be included if lsof defines _KERNEL, which normal programs > > shouldn't. > > So I think this should be considered a bug in lsof. > > -Alan > > > we *HAVE* to define _KERNEL, to get at the kernel structures..... Then you have to follow the rules (from style(9))... If either or is needed, include it before other include files. ( includes ; do not include both.) Typically, if you're including anything from sys/ you'll need sys/types.h first. -- Ian