From owner-svn-ports-head@FreeBSD.ORG Fri Mar 15 00:06:34 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8773283F; Fri, 15 Mar 2013 00:06:34 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from winston.madpilot.net (winston.madpilot.net [78.47.75.155]) by mx1.freebsd.org (Postfix) with ESMTP id 32D0334A; Fri, 15 Mar 2013 00:06:34 +0000 (UTC) Received: from winston.madpilot.net (localhost [127.0.0.1]) by winston.madpilot.net (Postfix) with ESMTP id 3ZRnBw0qwqzFTJ7; Fri, 15 Mar 2013 01:06:32 +0100 (CET) X-Virus-Scanned: amavisd-new at madpilot.net Received: from winston.madpilot.net ([127.0.0.1]) by winston.madpilot.net (winston.madpilot.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K0nkVLmRIdAE; Fri, 15 Mar 2013 01:06:30 +0100 (CET) Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206]) by winston.madpilot.net (Postfix) with ESMTPSA; Fri, 15 Mar 2013 01:06:30 +0100 (CET) Message-ID: <51426606.3050704@FreeBSD.org> Date: Fri, 15 Mar 2013 01:06:30 +0100 From: Guido Falsi User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130309 Thunderbird/17.0.4 MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r313841 - head/comms/openobex References: <201303102105.r2AL5C2o048218@svn.freebsd.org> <513E5682.1070704@FreeBSD.org> <20130312014941.GC92762@FreeBSD.org> <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk> <51426349.7070003@FreeBSD.org> In-Reply-To: <51426349.7070003@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, Max Brazhnikov , Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2013 00:06:34 -0000 On 03/15/13 00:54, Guido Falsi wrote: > On 03/12/13 13:48, Eitan Adler wrote: >> On 12 March 2013 07:18, Max Brazhnikov wrote: >>> On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote: >>>> On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote: >>>>>>> Would it be feasible to make DOXYGEN default for bulk pacakge >>>>>>> building >>>>>>> cases but not for regular port users (that is, hide it behind >>>>>>> BATCH or >>>>>>> PACKAGE_BUILDING)? >>>>> >>>>> I do like your idea. >>>>> >>>>> I have tested the port with the following stanza after OPTIONS_DEFINE: >>>>> >>>>> .if !defined(BATCH) && !defined(PACKAGE_BUILDING) >>>>> OPTIONS_DEFAULT+= DOXYGEN >>>>> .endif >>>>> >>>>> It does work as expected, is this what you had in mind? >>>> >>>> Yes, exactly. >>>> >>>>> Should I check only against one of the two variables? >> >> Users will sometimes set BATCH to avoid interaction with the ports >> tree. I believe they would not expect it changes dependencies as >> well. >> PACKAGE_BUILDING seems more correct in this case. >> > > My logic was inverted, rereading danfe statement he wants DOXYGEN on for > PACKAGE_BUILDING and off for regular builds, like this: > > .if !defined(PACKAGE_BUILDING) > OPTIONS_DEFAULT+= DOXYGEN > .endif I still wrote it with inverted logic, I meant: .if defined(PACKAGE_BUILDING) OPTIONS_DEFAULT+= DOXYGEN .endif -- Guido Falsi