From owner-freebsd-hackers@FreeBSD.ORG Sat Oct 21 16:26:12 2006 Return-Path: X-Original-To: freebsd-hackers@FreeBSD.org Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F1C516A40F; Sat, 21 Oct 2006 16:26:12 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97A3243D55; Sat, 21 Oct 2006 16:26:07 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (unknown [82.233.239.98]) by smtp2-g19.free.fr (Postfix) with ESMTP id B1A27758E4; Sat, 21 Oct 2006 18:26:06 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id C201E9E6C2; Sat, 21 Oct 2006 16:26:35 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id A7B95405B; Sat, 21 Oct 2006 18:26:35 +0200 (CEST) Date: Sat, 21 Oct 2006 18:26:35 +0200 From: Jeremie Le Hen To: Ruslan Ermilov Message-ID: <20061021162635.GS53114@obiwan.tataz.chchile.org> References: <20061020150848.GQ53114@obiwan.tataz.chchile.org> <20061020191332.GC59856@rambler-co.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061020191332.GC59856@rambler-co.ru> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: freebsd-hackers@FreeBSD.org, Jeremie Le Hen Subject: Re: src.conf(5) seems to affect ports build X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2006 16:26:12 -0000 Hi Ruslan, On Fri, Oct 20, 2006 at 11:13:32PM +0400, Ruslan Ermilov wrote: > On Fri, Oct 20, 2006 at 05:08:48PM +0200, Jeremie Le Hen wrote: > > Hi, > > > > src.conf(5) manual page states: > > > > % The src.conf file contains settings that will apply to every build > > % involving the FreeBSD source tree; see build(7). > > % ... > > % The only purpose of src.conf is to control the compilation of the FreeBSD > > % sources, which are usually found in /usr/src. > > > > However, share/mk/bsd.port.mk includes which in turn includes > > /etc/src.conf. Therefore if I have some WITH_/WITHOUT_ knob in it > > which affects CFLAGS, they will be taken into account even for port builds. > > > > Is it the expected behaviour ? Maybe WITH(OUT)_ should simply avoid > > modifying CFLAGS (though I think this might become useful in the near > > future). > > > See if the attached patch helps. If it does, I'll commit. I've > never heard back on this patch after I sent it to obrien@. This patch works correctly. Would you explain me why assigning /dev/null to _SRCCONF don't work in the current version of bsd.port.mk ? Also, your patch avoids performing the WITH(OUT)_* stuff for ports in order to prevent from polluting the namespace. If there is to be some WITH(OUT)_* knobs which leads to CFLAGS modification in the future (I'm thinking about ProPolice with the upcoming GCC 4.1), wouldn't it be worth benefiting this framework for ports ? Thank you. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >