From owner-freebsd-multimedia@FreeBSD.ORG  Tue Jun 12 04:04:23 2007
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
X-Original-To: multimedia@FreeBSD.org
Delivered-To: freebsd-multimedia@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4FA3916A400
	for <multimedia@FreeBSD.org>; Tue, 12 Jun 2007 04:04:23 +0000 (UTC)
	(envelope-from sra@hactrn.net)
Received: from cyteen.hactrn.net (cyteen.hactrn.net [66.92.66.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C25E13C45B
	for <multimedia@FreeBSD.org>; Tue, 12 Jun 2007 04:04:23 +0000 (UTC)
	(envelope-from sra@hactrn.net)
Received: from thrintun.hactrn.net (thrintun.hactrn.net
	[IPv6:2002:425c:4242:0:219:d1ff:fe12:5d30])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "thrintun.hactrn.net",
	Issuer "Grunchweather Associates" (verified OK))
	by cyteen.hactrn.net (Postfix) with ESMTP id 2873E2844E;
	Tue, 12 Jun 2007 03:45:37 +0000 (UTC)
Received: from thrintun.hactrn.net (localhost [IPv6:::1])
	by thrintun.hactrn.net (Postfix) with ESMTP id 5371222828;
	Mon, 11 Jun 2007 23:45:36 -0400 (EDT)
Date: Mon, 11 Jun 2007 23:45:35 -0400
From: Rob Austein <sra@hactrn.net>
To: multimedia@FreeBSD.org
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Message-Id: <20070612034536.5371222828@thrintun.hactrn.net>
Cc: 
Subject: multimedia/tovid bug (and patch)
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2007 04:04:23 -0000

Environment:

  FreeBSD thrintun.hactrn.net 6.2-STABLE FreeBSD 6.2-STABLE #26: Sat May 19 09:04:40 EDT 2007     sra@thrintun.hactrn.net:/usr/obj/usr/src/sys/THRINTUN  i386
  GNU bash, version 3.1.17(0)-release (i386-portbld-freebsd6.1)

Symptom:

  After running makemenu, makexml, and makedvd, dvdauthor quits with a
  complaint about not being able to find a seventh button in the DVD
  menu I created, which is odd since I only asked for six buttons.

Analysis:

  Bad shell quoting in a test command results in makemenu adding a
  "Back" button that neither I nor makexml knew about, so dvdauthor
  was right to complain.

Patch:

--- src/makemenu.sh.~1~	Sun Dec 18 14:05:53 2005
+++ src/makemenu.sh	Mon Jun 11 23:03:45 2007
@@ -315,7 +315,7 @@
 
 
 # Use a foreground canvas the size of the background minus safe area
-if [[ -n $SAFE_AREA ]]; then
+if [[ -n "$SAFE_AREA" ]]; then
   FG_WIDTH=`expr $WIDTH \* 4 \/ 5`
   FG_HEIGHT=`expr $HEIGHT \* 4 \/ 5`
 else
@@ -377,7 +377,7 @@
 done
 
 # If there was a "back", add it at the end
-if [[ -n $BACK_BUTTON ]]; then
+if [[ -n "$BACK_BUTTON" ]]; then
   # Leave an empty line
   CUR_Y=$NEXT_Y
   NEXT_Y=`expr $NEXT_Y \+ $TITLE_SPACING`