From owner-freebsd-ports@FreeBSD.ORG  Fri Jan 14 22:06:45 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26F761065694
	for <ports@freebsd.org>; Fri, 14 Jan 2011 22:06:45 +0000 (UTC)
	(envelope-from rea@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id C90098FC13
	for <ports@freebsd.org>; Fri, 14 Jan 2011 22:06:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru;
	s=two; 
	h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
	bh=QbE5N2MeSMMF0UfwPc2j/p51vm3qZ7u35hSOJZNgYmE=; 
	b=eIsaqWE8DqKsZQtcKeheEvr+Wifpnr9DTAcZVChxpyL6AuuckMNwVQh1uVtVnp4S0CXBpxd75Y38sic1wQWtamt08nGcffrNRc/4zIjcW10eVDvRUFk2kdygvJ0Hvj13mEKjuOy52lxEE9JHF0IYrkEawPzkNjhhYZ4lmTD43nTwdV7d1CeJZYla0UwEcbmQrYaqR9BeITDlWPYZr3feC0OpCUQpd+oxmIEoWXnkQmvfrRbQQhKyvgi7ad6gdsZ8CfLibSn8rU3AmsRRB4TQBKrbHJB75scCk41fPcJURuOoADbiJOcWV/lmeR8LGZbwrVDJp4GhdYUg3ceFpgKGug==;
Received: from amnesiac.at.no.dns (ppp91-78-117-186.pppoe.mtu-net.ru
	[91.78.117.186])
	by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256)
	id 1Pdrn9-0006CC-77; Sat, 15 Jan 2011 01:06:43 +0300
Date: Sat, 15 Jan 2011 01:06:40 +0300
From: Eygene Ryabinkin <rea@freebsd.org>
To: joeb <joeb@a1poweruser.com>
Message-ID: <GNeeIgIT+A6NrEwDSUikW2bp9IY@EpuHi/k2ZcZT1QGetG2qjJtOO3A>
References: <NBECLJEKGLBKHHFFANMBMEMHCOAA.joeb@a1poweruser.com>
	<ULu+Odl/+xnlB08wO2KgQl1AdlU@fEEwdAuY7Lvf1o+SaK2fw+gdbpE>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="uZ3hkaAS1mZxFaxD"
Content-Disposition: inline
In-Reply-To: <ULu+Odl/+xnlB08wO2KgQl1AdlU@fEEwdAuY7Lvf1o+SaK2fw+gdbpE>
Sender: rea@codelabs.ru
Cc: ports@freebsd.org
Subject: Re: Attention  ports committers
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jan 2011 22:06:45 -0000


--uZ3hkaAS1mZxFaxD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Sat, Jan 15, 2011 at 12:46:02AM +0300, Eygene Ryabinkin wrote:
> A couple of things about the port:
[...]

Two more things.

There is INSTALL_MAN macros that should be used for manpage
installation.  Also, ${MANPREFIX}/man/man8/ is better spelled as
${MAN8PREFIX}/man/man8/ and you can use the following construct:
{{{
=2Efor m in ${MAN8}
	${INSTALL_MAN} ${WRKSRC}${m} ${MAN8PREFIX}/man/man8/${m}
=2Eendfor
}}}
to automate the installation.

Perhaps, ${CAT} ${PKGMESSAGE} is better be silenced by writing
'@${CAT} ${PKGMESSAGE}'.
--=20
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

--uZ3hkaAS1mZxFaxD
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)

iF4EAREIAAYFAk0wyPAACgkQFq+eroFS7PtwRAEAlGJKpM0i+vu+N9wm7GrZa+0S
uRojiEU+vl9sqgRlG5MBAJEihxGcHlcYazNTo+/PPcAvWXvmUbtzA1yrdQeMifi+
=X0w1
-----END PGP SIGNATURE-----

--uZ3hkaAS1mZxFaxD--