Date: 15 Feb 2007 12:59:04 +0100 From: Tomas Olsson <tol@it.su.se> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-fs@freebsd.org, arla-drinkers@stacken.kth.se Subject: Re: Arla on FreeBSD Message-ID: <lsrhctn6393.fsf@kashyyyk.ite.kth.se> In-Reply-To: <20070215104537.GC39168@deviant.kiev.zoral.com.ua> References: <6FC9F9894A9F8C49A722CF9F2132FC2204C9DAB6@ms05.mailstreet2003.net> <45D1F30A.6080403@freebsd.org> <eqsut3$6a3$1@sea.gmane.org> <20070213192906.U726@chrishome.localnet> <20070214162938.GA96725@keira.kiwi-computer.com> <20070214173211.L1054@chrishome.localnet> <20070214170808.GC96725@keira.kiwi-computer.com> <lsrvei45pq1.fsf@kashyyyk.ite.kth.se> <20070215044707.GA39168@deviant.kiev.zoral.com.ua> <lsrmz3f680v.fsf_-_@kashyyyk.ite.kth.se> <20070215104537.GC39168@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Kostik Belousov <kostikbel@gmail.com> writes:
> On Thu, Feb 15, 2007 at 11:16:00AM +0100, Tomas Olsson wrote:
> > The interesting part is how we open and access the cache files, and from
> > what context. arlad is in chroot() to avoid recursive lookups across /, and
> > it seems like a good idea to avoid such lookups now too.
> >
> > So the main question is how to properly do VOP_{LOOKUP,CREATE,WRITE} etc on
> > cache files in this dual context world, without mixing identities in bad
> > ways or confusing the OS too much.
> >
> > The currently messed up code lives in
> > http://cvsweb.stacken.kth.se/cvsweb.cgi/arla/nnpfs/bsd/
> >
> > Most interesting is nnpfs_vnodeops-common.c (nnpfs_write_common()) and
> > nnpfs_blocks.c (open_file())
>
> I made really quick look at the places you mentioned. I have some
> comment for open_file(). For FreeBSD >= 6.x, the right way to open vnode
> from the kernel code is to use vn_open() (and then vn_close()) API.
>
Great! Sounds reasonable.
We currently open the cache files from nnpfs' VOPs, are there any risks
(deadlock?) involved if one passes an absolute path to vn_open() in such a
context? I'd have liked to do use arlad's thread for this, but vput()
explicitly uses curthread deep down in namei. Also, users are not normally
allowed to access the cache files directly so some OSes complain on such a
lookup with user creds; would that be a problem here?
Of course, we wouldn't have to worry about such things if we just kept the
vnode handy for each cache block file. Maybe it's a price worth paying.
thanks
/t
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?lsrhctn6393.fsf>