From owner-freebsd-bugs  Mon May 27 14:10:06 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id OAA12633
          for bugs-outgoing; Mon, 27 May 1996 14:10:06 -0700 (PDT)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id OAA12614;
          Mon, 27 May 1996 14:10:03 -0700 (PDT)
Resent-Date: Mon, 27 May 1996 14:10:03 -0700 (PDT)
Resent-Message-Id: <199605272110.OAA12614@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, gary@palmer.demon.co.uk
Received: from palmer.demon.co.uk (palmer.demon.co.uk [158.152.50.150])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA11996
          for <FreeBSD-gnats-submit@FreeBSD.ORG>; Mon, 27 May 1996 14:06:28 -0700 (PDT)
Received: (from gary@localhost)
	  by palmer.demon.co.uk (sendmail/PALMER-1) id WAA02868;
	  Mon, 27 May 1996 22:06:04 +0100 (BST)
Message-Id: <199605272106.WAA02868@palmer.demon.co.uk>
Date: Mon, 27 May 1996 22:06:04 +0100 (BST)
From: Gary Palmer <gpalmer@FreeBSD.ORG>
Reply-To: gary@palmer.demon.co.uk
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/1265: warnings in pcv
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         1265
>Category:       kern
>Synopsis:       warnings in pcv
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 27 14:10:01 PDT 1996
>Last-Modified:
>Originator:     Gary Palmer
>Organization:
None
>Release:        FreeBSD 2.1-STABLE i386
>Environment:

FreeBSD's current PCVT version

>Description:

If you compile pcvt with -Wunused, you get plenty of warings like:

../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'

This is because pcvt uses an inb() from the keyboard controller in an
attempt to get a delay which is slightly less processor dependant
than DELAY().

Bruce commented:

pcvt should just use DELAY().  DELAY() isn't perfect, but neither is pcvt's
inb() method.

>How-To-Repeat:

Add -Wunused to the kernel Makefile.

>Fix:
	
Move from the inb() to DELAY().

>Audit-Trail:
>Unformatted: