From owner-svn-src-all@FreeBSD.ORG Sun Dec 29 21:28:27 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04345618; Sun, 29 Dec 2013 21:28:27 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B06AE1939; Sun, 29 Dec 2013 21:28:26 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id rBTLSPu6041071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 29 Dec 2013 13:28:26 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id rBTLSPfI041070; Sun, 29 Dec 2013 13:28:25 -0800 (PST) (envelope-from jmg) Date: Sun, 29 Dec 2013 13:28:25 -0800 From: John-Mark Gurney To: Pedro Giffuni Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common Message-ID: <20131229212825.GE99167@funkthat.com> References: <201312252245.rBPMjX5J046556@svn.freebsd.org> <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> <52C08B47.70106@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52C08B47.70106@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sun, 29 Dec 2013 13:28:26 -0800 (PST) Cc: "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , Dimitry Andric , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2013 21:28:27 -0000 Pedro Giffuni wrote this message on Sun, Dec 29, 2013 at 15:51 -0500: > On 26.12.2013 06:13, Dimitry Andric wrote: > >On 26 Dec 2013, at 02:51, Adrian Chadd wrote: > >>I'd prefer you didn't remove unused code in drivers like this. If you > >>must, #if 0 them out. > >I don't mind either way, but some other people are very much opposed to > >littering code with #if 0'd sections. So, how do to determine what is > >right in each situation? :-) > > > > FWIW, I am also in favor of removing instead of #if 0. > If we really need the code back, we have subversion for that. > > I guess an exception would be on contributed code, where one > still wants to keep things similar. > > Just my 0.02$, no strong feelings about either way. My vote for code like this to #if 0 it out.. The reason being is that this is generic hardware register access, and it's likely that if it is removed and someone needs it, they'll write their own instead of dig it out of history, since they might not even realize that it even existed... Though can't we annotate it as unused? Since it is static inline, the compiler should end up not including it in the object. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."