From owner-freebsd-current@FreeBSD.ORG Sat Aug 21 18:32:43 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0B3D16A4CE; Sat, 21 Aug 2004 18:32:43 +0000 (GMT) Received: from mail.mcneil.com (rrcs-west-24-199-45-54.biz.rr.com [24.199.45.54]) by mx1.FreeBSD.org (Postfix) with ESMTP id 552C043D48; Sat, 21 Aug 2004 18:32:43 +0000 (GMT) (envelope-from sean@mcneil.com) Received: from localhost (localhost.mcneil.com [127.0.0.1]) by mail.mcneil.com (Postfix) with ESMTP id D414AFD06B; Sat, 21 Aug 2004 11:32:42 -0700 (PDT) Received: from mail.mcneil.com ([127.0.0.1]) by localhost (server.mcneil.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45462-02; Sat, 21 Aug 2004 11:32:42 -0700 (PDT) Received: from [24.199.45.54] (mcneil.com [24.199.45.54]) by mail.mcneil.com (Postfix) with ESMTP id 265DDFD029; Sat, 21 Aug 2004 11:32:42 -0700 (PDT) From: Sean McNeil To: Tim Kientzle In-Reply-To: <41278CC4.6020007@freebsd.org> References: <1092777586.92327.9.camel@server.mcneil.com> <20040817213813.GE3827@gothmog.gr><4127841D.6050104@freebsd.org> <41278CC4.6020007@freebsd.org> Content-Type: text/plain Message-Id: <1093113161.45510.4.camel@server.mcneil.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sat, 21 Aug 2004 11:32:42 -0700 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at mcneil.com cc: Giorgos Keramidas cc: freebsd-current@freebsd.org Subject: Re: bsdtar core dumps X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2004 18:32:43 -0000 On Sat, 2004-08-21 at 10:56, Tim Kientzle wrote: > Maxim Konovalov wrote: > > On Sat, 21 Aug 2004, 10:19-0700, Tim Kientzle wrote: > > > > [...] > > > >>The code you've pointed to above concerns > >>me because of the part about: > >>if (n == 0) { > >>... > >>n = 1; > >> } > >>That ain't right: If I told vsnprintf the buffer > >>size was zero, it should treat it as such. If I > >>meant "one", I would have said "one." > > > > That code was committed in rev. 1.21 vsnprintf.c, a workaround for a > > memory leak, bin/36175. > > Ahh... I see now. Apparently, I've either had too > much caffeine or not enough. I'll try to adjust that. ;-) > > But the code in vsnprintf.c is correct. The n=1 > is the size of the stack-allocated temp buffer, not the > user buffer. That makes Sean's idea of something > Alpha-specific seem more likely. I think you mean amd64-specific. > Sean, could you take a look at this bug report: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=36175 > > Try running the program there under "How To Repeat" > and tell us what happens. That should shed some > light on the subject. Just tried it and the size of the program never grows here. Nor is there a core dump. > In the meantime, do try the patch I sent you earlier. > At the very least, I'd like to get bsdtar to stop > dumping core on you. I will try your patch soon, but it probably will not be until another 24 hours. Thanks, Sean