From nobody Sat Dec 4 01:21:26 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 041BD18BC934 for ; Sat, 4 Dec 2021 01:21:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J5X2t5GLCz3Qfg for ; Sat, 4 Dec 2021 01:21:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 96EC41B800 for ; Sat, 4 Dec 2021 01:21:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B41LQMC077904 for ; Sat, 4 Dec 2021 01:21:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B41LQFZ077903 for bugs@FreeBSD.org; Sat, 4 Dec 2021 01:21:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260176] nfsrvd_verify() passes sfp=NULL to nfsv4_loadattr(), which can crash Date: Sat, 04 Dec 2021 01:21:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rmacklem@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638580886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7OmleaBdz959w93ocCC/3MJKvTObPAdXkl/Dlqs6wM4=; b=b3YFWvjFkSbh2OYCYZV43NXS/aJF8zRXUIkB04hjNSst2zTwi+zzvvK+mi6qfVPyxu0raB Bp/rpJ/tLek95QulMkcgA+T3xXBWsuWkB2g4re7JA7H20to65kUVY6rmMEbz2P5+FzNzGH PS9u7dcCcqq6AitlR50IsuDUfJEHxAL29zOPHfduPDVFABJluQXpj3a0y6lur8VeU7MpgZ xCAmMJgGnMJuN3X7nqh359ryaopQNNmmgdw45bq2LqcfzEjE3d33YN0lLq9DsxF2itwAfc WaxV7IEfFtq/BQo00OfSPxcEoMbTdjoOAZOVRZDqe8OFyXTybvAvq+WnqWC1aQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638580886; a=rsa-sha256; cv=none; b=tqx1Yxor5cOlvQ0zFh7P0xYhZ1jZ7z303XZWKQAafGxyMV5WNn4Soh+u6AdgIZJfxXLhwc 4yKbu5qTegakoJc6hROxm3mGYop8rpBDnq6UM/JsmR0/7DtYSF6QVHEkdun8xuX2howU+Q CeRKWsgiQLR7g61b7l54Xdj3Lsm5/yxooOtZJ2SBTGA75d9Z1QGoNJHFS8VqpJinur9TVD U/170v3x2kKM9dWkinDvKM6IUYCdYU/dVpZnP7LL2NXPNO7t+7zaHFRMUq2setzeP2egBZ 9xnWhd4GhBqXTAZK87VFXVHQt0vcGXdbDIrOpuzo/ohb/8D7zzhLhkac1yg5iA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260176 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open Assignee|bugs@FreeBSD.org |rmacklem@FreeBSD.org --- Comment #1 from Rick Macklem --- Created attachment 229867 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D229867&action= =3Dedit Just reply not same for verify of file system stats attributes To correctly verify file system stats like FILESFREE is somewhat involved and, since no crashes are being reported, not being done by extant NFSv4 clients. Also, I do not see how file system stats that change constantly could be effectively used by VERIFY/NVERIFY. As such, this patch changes the code to just return NFSERR_NOTSAME for them. If a case where the VERIFY needs to work for any of these attributes, a patch for that could be created. This should avoid the crashes. Maybe the reporter can confirm that it fixes the problem for him? --=20 You are receiving this mail because: You are the assignee for the bug.=