From owner-svn-src-all@freebsd.org Fri May 13 01:30:02 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0C8DB375A9; Fri, 13 May 2016 01:30:02 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 5B27E1FFE; Fri, 13 May 2016 01:30:02 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-106-149-109.carlnfd1.nsw.optusnet.com.au (c122-106-149-109.carlnfd1.nsw.optusnet.com.au [122.106.149.109]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id D9234426A25; Fri, 13 May 2016 11:29:53 +1000 (AEST) Date: Fri, 13 May 2016 11:29:53 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Don Lewis cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299584 - head/usr.sbin/binmiscctl In-Reply-To: <201605130114.u4D1Edeg031694@repo.freebsd.org> Message-ID: <20160513111917.N10080@besplex.bde.org> References: <201605130114.u4D1Edeg031694@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=EfU1O6SC c=1 sm=1 tr=0 a=R/f3m204ZbWUO/0rwPSMPw==:117 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=jfy4bp20KS1t31fDf4cA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 01:30:02 -0000 On Fri, 13 May 2016, Don Lewis wrote: > Log: > Mark usage() as __dead2 so that Coverity doesn't think that execution > continues after the call and uses a negative array subscript. > > Reported by: Coverity > CID: 1305629 This was just a bug in Coverity. Now it is also a style bug. usage() doesn't return since it finishes with exit() and this is marked with __dead2. It is a style bug to declare usage() and similar functions that obviously don't return as __dead2. Thus can only be obvious only obvious for static function. Coverity should do more global checking and not need this markup for some extern functions. Even lint can do that. Only about 32 of 451 declarations of usage() in /usr/src have this style bug. Bruce