From owner-cvs-all@FreeBSD.ORG  Sat Apr  3 15:33:29 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7FB5F16A4CE; Sat,  3 Apr 2004 15:33:29 -0800 (PST)
Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F1DD543D45; Sat,  3 Apr 2004 15:33:28 -0800 (PST)
	(envelope-from marcel@xcllnt.net)
Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201])
	by ns1.xcllnt.net (8.12.11/8.12.11) with ESMTP id i33NXSWG079224;
	Sat, 3 Apr 2004 15:33:28 -0800 (PST)
	(envelope-from marcel@piii.pn.xcllnt.net)
Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1])
	i33NXSVc035186;	Sat, 3 Apr 2004 15:33:28 -0800 (PST)
	(envelope-from marcel@dhcp01.pn.xcllnt.net)
Received: (from marcel@localhost)
	by dhcp01.pn.xcllnt.net (8.12.11/8.12.11/Submit) id i33NXSP8035185;
	Sat, 3 Apr 2004 15:33:28 -0800 (PST)
	(envelope-from marcel)
Date: Sat, 3 Apr 2004 15:33:28 -0800
From: Marcel Moolenaar <marcel@xcllnt.net>
To: Lukas Ertl <le@FreeBSD.org>
Message-ID: <20040403233328.GA34996@dhcp01.pn.xcllnt.net>
References: <200404032226.i33MQhSf088122@repoman.freebsd.org>
	<20040403225124.GB34949@dhcp01.pn.xcllnt.net>
	<20040404010004.M9970@leelou.in.tern>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040404010004.M9970@leelou.in.tern>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/growfs Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Apr 2004 23:33:29 -0000

On Sun, Apr 04, 2004 at 01:02:09AM +0200, Lukas Ertl wrote:
> On Sat, 3 Apr 2004, Marcel Moolenaar wrote:
> 
> > On Sat, Apr 03, 2004 at 02:26:43PM -0800, Lukas Ertl wrote:
> > > le          2004/04/03 14:26:43 PST
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sbin/growfs          Makefile
> > >   Log:
> > >   Temporarily go back to WARNS=0 until I can figure out what's breaking
> > >   the {powerpc, sparc64, ia64} tinderboxes.
> >
> > The problem is in sys/ufs/ffs/fs.h. I think if you change
> >     ((int32_t *)((u_int8_t *)(cgp) + (cgp)->cg_xxx))
> > to
> >     ((int32_t *)((uintptr_t)(cgp) + (cgp)->cg_xxx))
> >
> > for the definitions of cg_inosused(), cg_blksfree(), cg_clustersfree()
> > and cg_clustersum() you should be ok. I haven't tested it...
> 
> Apart from growfs, the cg_clustersum() macro is used in newfs, fsck_ffs,
> and dumpfs, AFAICS.  They all are compiled with WARNS=2....

Nonetheless, the change does actually remove most of the alignment
warnings. I have no idea what's different in newfs or others. JFYI,

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net