Date: Thu, 14 Dec 2017 15:52:44 -0500 From: Dan Langille <dan@langille.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Dan Langille <dvl@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r456223 - in head/www: . Stikked Stikked/files Message-ID: <D0198235-A61D-4E57-8C15-B518411B9092@langille.org> In-Reply-To: <b18134c7-0906-edf4-cc3f-f900b3159b33@FreeBSD.org> References: <201712131744.vBDHicEP086668@repo.freebsd.org> <b18134c7-0906-edf4-cc3f-f900b3159b33@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 14, 2017, at 8:39 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 > Le 13/12/2017 =C3=A0 18:44, Dan Langille a =C3=A9crit : >> +WANT_PGSQL=3D client >> +WANT_SQLITE=3D client >> +WANT_MYSQL=3D client >=20 > What are those for ? You don't use them anywhere in the port. >=20 >> +PGSQL_USE=3D PHP=3Dpdo_pgsql >=20 > This is also never used. That's terrible. I think that is cruft leftover from when I was trying = to get this to work with PDO. I abandoned that when I realized it would also work = without. >=20 >> Added: head/www/Stikked/pkg-plist >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- /dev/null 00:00:00 1970 (empty, because file is newly = added) >> +++ head/www/Stikked/pkg-plist Wed Dec 13 17:44:38 2017 = (r456223) >> @@ -0,0 +1,3436 @@ >> +%%ETCDIR%%/stikked.php.sample >=20 > @sample ? A valid point, yes, that was my intent. >=20 >> + >=20 > Empty line I'd always left empty lines between different sections of pkg-plist for = readability. Gone. See https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D456372 >=20 -- Dan Langille - BSDCan / PGCon dan@langille.org --Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQF8BAEBCgBmBQJaMuScXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDRUE3MDlFMjg3QjI3RkNCMjA0QzgxMDEy MTREM0Q1RDREQTc1RUQzAAoJECFNPV1Np17TYF4H/imn+bs39kiKsUydb5gcU0Kn VAdkgJoci4EIaN+5PvYkDn72k2LHwfBXi6x9kg9ajcbDN1P+DJBFA3eKrIwJBaLF E6az+gExyBCMWeK8TxkByXgkN2yBq8yPMu6bzYbuJjj7+qpCQ71/Gz29v1wcEAmv Dw6MXVMBQ0Uxxl1T8zoDvpK90CgXSlXHdSuT9jY6kD/5FqqKHWoIgPwuW3HUc4ni t6gHv/4YX+pohLL/+4eHMXyMeaVP4/BXI91Wq1QMN+EvNkFKxptUE27JfMOFYd/i TlM70ICR2YKkdxqZxppbeScFCTCrm7ydPb9D5PHTaVzqciR6OLVEwtyo+b4ea48= =cEhH -----END PGP SIGNATURE----- --Apple-Mail=_67AB6987-BDA6-49F9-9545-5947498D58A7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0198235-A61D-4E57-8C15-B518411B9092>