From nobody Mon Jan 8 17:50:02 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T81mW1Q1Dz56FRQ; Mon, 8 Jan 2024 17:50:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T81mW0lF1z3xS0; Mon, 8 Jan 2024 17:50:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704736203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aLqCQSnx8NwqYbh5C2BhoxXd1lVpFefAqty3JE0WJso=; b=wmk78iph9WPNqT6gnxyaVkZL7TvKTRuZX+wPwW4+8d8ckhu4hOZO9Au/5yl3py0Ypc1Ap7 /CRvREKgFF9/YrP04Cnn92ZiR3jO8YB/Bp/0oMdR65NlTdEXq+gI8JFsReINzjXc5mELO+ eccKI8ni1zgBkbOWi2goIOfXOFs523MkI0lyDgTUpi3Ld99m9NHnUquKeuIx6jsqRx3+Py 41mQd1lQy9NvioM25YoYFgt0wxOT7L7F7PBSh8xZJ81+v5uNAXZC5vxWDcC25cZwZnONu1 yNKXzQ3h3ekCxYvTw3FjIzDfG8f0gksEKSKG17vVYy46p0Gr229NN8Q0FnBMrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704736203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aLqCQSnx8NwqYbh5C2BhoxXd1lVpFefAqty3JE0WJso=; b=VuW9WPMD7DEb7JQ7IqpYLI6PstZszKmkx4HzZVydFumdkyLC2qYeHEUdGWxXBL5EEp2D4f jfDGzgyjlpo/NAiCSrzG3FiTzedoo7YUSABtnZfz3zUvsGP7dqUmm6awn3+pCZu+KnqNqa bU1oWi1UkE5a+5V5wwkPoYJ+Gyv9/PhFMZK6alYj/ttKcBQ1rDHBL4hHt6QCcmU3kVV9bT VBQGtLgv8b7gk0DHXpp413DeWj+dtBbBdiN9IF7CPPA0BmvN3+Ype9hJWzzBR8dH7EPdZZ 5Or4Vu2WsNvxWRZwmw3mKNPlFzaeGdkklIf++BCw8QW93O7nR+4J/A03oKKMlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704736203; a=rsa-sha256; cv=none; b=PY62FV6HdHlhFC3QVQys0VH6ZKkOP6FsvFXLPNIw5QkJzKanlJ3EOSAQvA4lnvNq/m7jXx sWM4CQj8stfdD/bmPsyWmKzgbQTCtap2c3YjUBVMbPyloCCp4LOEvqMRbMotIZJsFkh+iT Gbv43SwrDDSIZtNoMba/OP5WB+w/mnTOELVQmZrRIIBdA1l8o0pvcd7rHxWurUwiipF2q5 lVrsj3iOMOKExZlZm5JzM+TzMwuwaKR/OTZ7Ufv1EQbedn8x5rqMem/a1dTnSK8acoS3uh BNAORwx6KAXYXnSIFtzU6YQ/awoV8OMv4KRKHxAXjupIdnZcWCWlHsJYmaiiLg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T81mV6x4dzHFS; Mon, 8 Jan 2024 17:50:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 408Ho220041184; Mon, 8 Jan 2024 17:50:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 408Ho27l041179; Mon, 8 Jan 2024 17:50:02 GMT (envelope-from git) Date: Mon, 8 Jan 2024 17:50:02 GMT Message-Id: <202401081750.408Ho27l041179@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: a4a838a31ac2 - main - bhyveload: make error printing consistent List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a4a838a31ac24e19c8ee68d45cf5234615d0b958 Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=a4a838a31ac24e19c8ee68d45cf5234615d0b958 commit a4a838a31ac24e19c8ee68d45cf5234615d0b958 Author: Kyle Evans AuthorDate: 2024-01-08 17:49:40 +0000 Commit: Kyle Evans CommitDate: 2024-01-08 17:49:40 +0000 bhyveload: make error printing consistent Previously we used a mix of perror(3) + exit(3) and err(3); standardize on the latter instead. This does remove one free() in an error path, because we're decidedly leaking a lot more than just the loader name there (loader handle, vcpu, vmctx...) anyways. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D43331 --- usr.sbin/bhyveload/bhyveload.c | 49 ++++++++++++++---------------------------- 1 file changed, 16 insertions(+), 33 deletions(-) diff --git a/usr.sbin/bhyveload/bhyveload.c b/usr.sbin/bhyveload/bhyveload.c index 4f16f58bfc9f..4d89393424f4 100644 --- a/usr.sbin/bhyveload/bhyveload.c +++ b/usr.sbin/bhyveload/bhyveload.c @@ -861,18 +861,14 @@ main(int argc, char** argv) need_reinit = 0; error = vm_create(vmname); if (error) { - if (errno != EEXIST) { - perror("vm_create"); - exit(1); - } + if (errno != EEXIST) + err(1, "vm_create"); need_reinit = 1; } ctx = vm_open(vmname); - if (ctx == NULL) { - perror("vm_open"); - exit(1); - } + if (ctx == NULL) + err(1, "vm_open"); /* * If we weren't given an explicit loader to use, we need to support the @@ -882,10 +878,8 @@ main(int argc, char** argv) cap_rights_t rights; bootfd = open("/boot", O_DIRECTORY | O_PATH); - if (bootfd == -1) { - perror("open"); - exit(1); - } + if (bootfd == -1) + err(1, "open"); /* * bootfd will be used to do a lookup of our loader and do an @@ -893,19 +887,15 @@ main(int argc, char** argv) * to the more usual lookup rights. */ if (caph_rights_limit(bootfd, cap_rights_init(&rights, - CAP_FSTATAT, CAP_LOOKUP, CAP_MMAP_RX, CAP_READ)) < 0) { - perror("caph_rights_limit"); - exit(1); - } + CAP_FSTATAT, CAP_LOOKUP, CAP_MMAP_RX, CAP_READ)) < 0) + err(1, "caph_rights_limit"); } vcpu = vm_vcpu_open(ctx, BSP); caph_cache_catpages(); - if (caph_enter() < 0) { - perror("caph_enter"); - exit(1); - } + if (caph_enter() < 0) + err(1, "caph_enter"); /* * setjmp in the case the guest wants to swap out interpreter, @@ -921,26 +911,19 @@ main(int argc, char** argv) if (need_reinit) { error = vm_reinit(ctx); - if (error) { - perror("vm_reinit"); - exit(1); - } + if (error) + err(1, "vm_reinit"); } vm_set_memflags(ctx, memflags); error = vm_setup_memory(ctx, mem_size, VM_MMAP_ALL); - if (error) { - perror("vm_setup_memory"); - exit(1); - } + if (error) + err(1, "vm_setup_memory"); loader_open(bootfd); func = dlsym(loader_hdl, "loader_main"); - if (!func) { - printf("%s\n", dlerror()); - free(loader); - return (1); - } + if (!func) + errx(1, "dlsym: %s", dlerror()); tcgetattr(consout_fd, &term); oldterm = term;