From owner-svn-ports-head@freebsd.org Wed Apr 18 19:17:12 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57C5DFA3D89; Wed, 18 Apr 2018 19:17:12 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vk0-x243.google.com (mail-vk0-x243.google.com [IPv6:2607:f8b0:400c:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1097E82689; Wed, 18 Apr 2018 19:17:11 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by mail-vk0-x243.google.com with SMTP id 203so1726642vka.12; Wed, 18 Apr 2018 12:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/oxsF3DldRM95tyeta89zz+fhn7TLGfuxt75+iLf7ys=; b=p4zfEvb5E2imwFaxGk4l7R83nPfto+OYA5GNb8j4emp4QhBQRxbclnAiCmCzS0eSQy a+AOgAMNM3W1pRIENaa8tTtzcszLET71RAC3XuIbEPaDTfcThbwM64KB06yFoP+yJ3gL X2/tVpPRTWahsno8RlY/CwksEIl2+L67CeMwUlvXi0nBMW4ZbHmnw6eMFHZW7s3I6XsN Fx9rYjBvwZu4LfTmLcKJoHWVsTGGUhjFntHqFR28GjRTCwfjLiR6C47h91vEgbWpSQw4 wJI6RcDLgceo7rxBKFw/dGCpLpe0RtMr1TXYo8ifqRjDHnL1iVjrEnXZHQjI2S3XQb65 TTEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/oxsF3DldRM95tyeta89zz+fhn7TLGfuxt75+iLf7ys=; b=rWULtJ7HdrQxOHjdsvBEhawjHW5Jx+jI9/uvizs2bU/B6VQ56P79D3gubd/kTu4aKP f/vT3V4pZ890CiREK4YdkT5g5i6ypiPMYF6H8mk3ERyPDpLcTJYs27yHWvY7esdlj6LP ifW5Q4g5ArbmPk4ExrfIHZT0faBcw+p7YPtAM/yHRmBvTKhSjacVkyqFwLN3x5lGrr6j PpbQTneSKKTORzqQCdDfirJQas91tAlcWb9/wksWuffh7rImRzDXEfrjmjheQUznTgsw d3H0iYNU9PHaVL/ONs/uDUrGD1rvBSj6/jUeMDSacpe+FqqEtnPNOMa3Z1uJrjOE1Ms4 8Jkg== X-Gm-Message-State: ALQs6tDDb1CKBaxO4iUVi9CbU37II3etsHcHKRrmdS0nMFqf0wVUaZ+N AQST+DYV+L4NTZemcRz2H96kxwkKLzohrrSUlk+OGxtk X-Google-Smtp-Source: AIpwx4/flutHhqq4MQPL9cotJ9qZRcsaPJE3EoSkU+o5RXpjeUfKhHyg8uJwpEJAZ9PrvcH4sd7AOVElamkFSC1Kj0M= X-Received: by 10.31.129.72 with SMTP id c69mr2467835vkd.171.1524079030132; Wed, 18 Apr 2018 12:17:10 -0700 (PDT) MIME-Version: 1.0 Sender: bsdkaffee@gmail.com Received: by 10.31.48.151 with HTTP; Wed, 18 Apr 2018 12:17:09 -0700 (PDT) In-Reply-To: <20180418182939.5w3jvcdemalycpq7@atuin.in.mat.cc> References: <201804172327.w3HNRLIF044763@repo.freebsd.org> <20180418080556.lh6ds7t6e34ackoi@atuin.in.mat.cc> <3174473.pFhRGbBKQR@beastie.bionicmutton.org> <20180418111002.b7ocgnvfo25s5ofk@ogg.in.absolight.net> <20180418182939.5w3jvcdemalycpq7@atuin.in.mat.cc> From: "Jason E. Hale" Date: Wed, 18 Apr 2018 15:17:09 -0400 X-Google-Sender-Auth: Y_QmiudCtUgtdiGMX1dQgUaowxM Message-ID: Subject: Re: svn commit: r467663 - in head/audio: . liblastfm liblastfm-qt5 liblastfm/files To: Mathieu Arnold Cc: Adriaan de Groot , ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 19:17:12 -0000 On Wed, Apr 18, 2018 at 2:29 PM, Mathieu Arnold wrote: > On Wed, Apr 18, 2018 at 05:49:52PM +0000, Jason E. Hale wrote: >> On Wed, Apr 18, 2018 at 7:10 AM, Mathieu Arnold wrote: >> > On Wed, Apr 18, 2018 at 10:21:16AM +0200, Adriaan de Groot wrote: >> >> On Wednesday, 18 April 2018 10:05:56 CEST Mathieu Arnold wrote: >> >> > On Tue, Apr 17, 2018 at 11:27:21PM +0000, Jason E. Hale wrote: >> >> > > Log: >> >> > > - Update audio/liblastfm to 1.0.9-5-g4433165 [1] >> >> > > - Add audio/liblastfm-qt5 slave port which provides a Qt 5 interface [1] >> >> > >> >> > Why not add flavors instead of a slave port? >> >> >> >> >> >> In an existing review https://reviews.freebsd.org/D14660 you (Mat) say of a >> >> different port >> >> >> >> """We currently do not accept flavors that add new packages though, so this >> >> change will be able to go in when ports-mgmt/poudriere is updated to 3.3.""" >> >> >> >> That would preclude flavorizing liblastfm, wouldn't it? There are a lot of Qt4/ >> >> Qt5 ports that could be flavorized and/or swept together like that. >> > >> > Mmmm, that sentence is not true any more, 3.3 was supposed to be the >> > first release to have the 32k packages limit fix, but as it was taking a >> > bit more time to get there, to the fix was backported to the 3.2 branch >> > and is in 3.2.6. So, flavorizing is possible now. (Still requires >> > portmgr approval.) >> > >> > >> >> I did submit a review for this (https://reviews.freebsd.org/D14667) a >> month ago and you rejected it, so I decided to move forward. Poudriere >> still has a bug in it where it is flavorizing the WRKDIR of the >> math/fftw3 dependency, however, which causes the build to fail without >> that ugly hack I put in. The port builds fine outside of poudriere >> without the hack. I did set up the port to be easily converted to >> FLAVORS, but maybe that bug should be fixed first before I re-attempt? > > So you completely missed the point about why I rejected the review in > the first place. It was so that no new packages would get there until > the 32k poudriere bug was solved in a release. Adding a slave port also > add a new package. > Yes, I suppose I did. You said "We do not currently accept flavors that add new packages." I read that as flavors that add new packages, not any new packages. I thought the bugs being worked out were flavor-related and wasn't aware of the 32k package limit in poudriere, nor of any ban of new packages in general. - Jason