From owner-freebsd-hackers@FreeBSD.ORG  Mon Aug 31 21:49:47 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C868106568B;
	Mon, 31 Aug 2009 21:49:47 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4BEFC8FC16;
	Mon, 31 Aug 2009 21:49:47 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id EFE2746B2C;
	Mon, 31 Aug 2009 17:49:46 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id 00A158A03E;
	Mon, 31 Aug 2009 17:49:45 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Andrew Brampton <brampton+freebsd-hackers@gmail.com>
Date: Mon, 31 Aug 2009 16:42:50 -0400
User-Agent: KMail/1.9.7
References: <d41814900908310318n113867dsf9e47f149b0e61b4@mail.gmail.com>
	<200908310804.27417.jhb@freebsd.org>
	<d41814900908311215o24cbded5y4c8dcb14ece5f670@mail.gmail.com>
In-Reply-To: <d41814900908311215o24cbded5y4c8dcb14ece5f670@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200908311642.50866.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Mon, 31 Aug 2009 17:49:46 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.4 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: jfv@freebsd.org, freebsd-hackers@freebsd.org
Subject: Re: netstat -i Ierrs column, Is it total, or per second?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2009 21:49:47 -0000

On Monday 31 August 2009 3:15:53 pm Andrew Brampton wrote:
> 2009/8/31 John Baldwin <jhb@freebsd.org>:
> > It should be total and it sounds like a bug in the device driver. =A0It=
=20
looks
> > like ixgbe_update_stats_counters() overwrites the accumulated value of
> > if_ierrors:
> >
> > =A0 =A0 =A0 =A0/* Rx Errors */
> > =A0 =A0 =A0 =A0ifp->if_ierrors =3D total_missed_rx + adapter->stats.crc=
errs +
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0adapter->stats.rlec;
> >
> > It also increments if_ierrors in ixgbe_rxeof(). =A0The driver should on=
ly do=20
one
> > or the other, but probably not both.
> >
> > --
> > John Baldwin
> >
>=20
> Thanks for your reply. I had wondered that, but looking at
> e1000/if_em.c it does a similar thing. However, a quick look at
> non-intel drivers and it seems others don't. So perhaps this is a
> problem across the intel drivers?
>=20
> So anyway I spent my afternoon reading the ixgbe spec sheet and
> creating the attached patch, which hopefully fixes this problem. I
> will forward this patch to freebsd <at> intel.com unless someone can
> point me toward the maintainers email address, or should I just create
> a PR?

I cc'd him on my earlier reply (jfv@) so he should have seen your patch=20
already.

=2D-=20
John Baldwin