From owner-svn-src-all@FreeBSD.ORG Mon Mar 14 12:59:31 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0199E106564A; Mon, 14 Mar 2011 12:59:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id C79168FC1E; Mon, 14 Mar 2011 12:59:30 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 63D0246B0C; Mon, 14 Mar 2011 08:59:30 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.10]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E8F378A01B; Mon, 14 Mar 2011 08:59:29 -0400 (EDT) From: John Baldwin To: Andriy Gapon Date: Mon, 14 Mar 2011 08:04:17 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <201103120909.p2C99P2j010783@svn.freebsd.org> <4D7C6DFC.8020504@freebsd.org> In-Reply-To: <4D7C6DFC.8020504@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103140804.17800.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 14 Mar 2011 08:59:30 -0400 (EDT) Cc: svn-src-head@freebsd.org, Alexander Leidinger , svn-src-all@freebsd.org, src-committers@freebsd.org, Artem Belevich Subject: Re: svn commit: r219561 - in head/sys: cddl/dev/systrace modules/dtrace modules/dtrace/dtraceall modules/dtrace/systrace_freebsd32 modules/dtrace/systrace_linux32 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2011 12:59:31 -0000 On Sunday, March 13, 2011 3:10:52 am Andriy Gapon wrote: > on 13/03/2011 08:35 Artem Belevich said the following: > > On Sat, Mar 12, 2011 at 12:14 PM, Alexander Leidinger > > wrote: > >> But this looks like it will be named linux32 in any case. In the short > >> term I would prefer: > >> ---snip--- > >> #if defined(__amd64__) > >> #define MODNAME "linux32" > >> #elif defined(__i386__) > >> #define MODNAME "linux" > >> #endif > >> ---snip--- > > > > Makes sense. It's what's done with freebsd syscalls -- 'freebsd' for > > native syscalls, freebsd32 for 32-bit compat. > > BTW, in my opinion, it might not make a lot of sense. > That is, we can have native and compat FreeBSD system calls, but Linux system > calls are always compat and never native, whether the emulation is for the same > arch or not. Explicit suffix makes things clearer. But that's just my opinion. However, if we were to go that route, you would need to have 'linux-i386', 'linux-x86-64', 'linux-alpha', etc. Recall that our Alpha port had Linux compat as well, so for it 'linux.ko' was a 64-bit ABI. I think it makes sense to assume that 'linux' maps to Linux compat for whatever the native platform of the running kernel is and to then use suffixes for other platform modes (such as 32-bit compat mode in amd64). -- John Baldwin