From owner-freebsd-current@FreeBSD.ORG Mon Aug 5 15:39:55 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 498C78C3; Mon, 5 Aug 2013 15:39:55 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-we0-x231.google.com (mail-we0-x231.google.com [IPv6:2a00:1450:400c:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AA3E223CC; Mon, 5 Aug 2013 15:39:54 +0000 (UTC) Received: by mail-we0-f177.google.com with SMTP id m46so2616280wev.36 for ; Mon, 05 Aug 2013 08:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=kPQHJyY1zBpzSc5B5/welaPohIM2GZ98sKK++lyvDW4=; b=Pw0hkiKfo5PAxwjytDZKGCpbNMBi66piKXeUjn/nHP7glfxYscy74Ym04YDak1aEAp QbNe4/kIU5eas8oYhv2OipZ5/40vrm6XYPIs9naTmJ2ZzC8SI4zBIQt7L7zck1UKbO5b zNby7Y+vUSWlJpoKhp28aSzEFYauhJWfXBGX+AcPZ+KeK8rKaSTuE4j01Ms7Sq+1uOng gQZJ5eiYDQCeqjhEO5F5SPgA2sR/Omh6Tzm8yPoQ5fmOCH6T+Tg32SphebR9uj7wHqc2 wjLR3JmtWkClCRc85tU5oepC4bnk94ms8Q0VgoNWn/HFi1YrbGy6+9Ab2BEiZwXOZBWk 676A== X-Received: by 10.194.110.39 with SMTP id hx7mr13581146wjb.4.1375717192906; Mon, 05 Aug 2013 08:39:52 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id z2sm22254726wiv.11.2013.08.05.08.39.50 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 05 Aug 2013 08:39:51 -0700 (PDT) Date: Mon, 5 Aug 2013 17:39:46 +0200 From: Mateusz Guzik To: Roman Divacky Subject: Re: Linux epoll(7) patch Message-ID: <20130805153946.GA29300@dft-labs.eu> References: <51FF7211.6020909@rawbw.com> <51FFC31D.3080304@mu.org> <20130805152556.GA37810@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130805152556.GA37810@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Yuri , Alfred Perlstein , current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Aug 2013 15:39:55 -0000 On Mon, Aug 05, 2013 at 05:25:56PM +0200, Roman Divacky wrote: > On Mon, Aug 05, 2013 at 08:22:05AM -0700, Alfred Perlstein wrote: > > On 8/5/13 2:36 AM, Yuri wrote: > > > There is the patch, suggested by Roman Divacky, implementing Linux > > > epoll(7) functionality: > > > http://rys.vlakno.cz/~rdivacky/patches/linux_epoll.patch > > > > > > This patch was suggested 5 years ago and was discussed on emulation@: > > > http://lists.freebsd.org/pipermail/freebsd-emulation/2008-March/004409.html > > > > > > http://lists.freebsd.org/pipermail/freebsd-emulation/2008-March/004428.html > > > > > > > > > Discussion stalled back then, and epoll is still unimplemented. > > > > > > Anybody can identify any issues with this patch? > > > Are there any alternatives? > > > > > > Yuri > > The patch is small. I too am wondering why it's not committed, was > > there any push back? > > iirc the main problem with the patch is that it doesnt work over fork, I never > got to implement that feature. > > Nevertheless it looks like the patch is useful even without that feature so > maybe it should just be commited? > What happens to fd after the fork? Is it closed or simply remains non-functional? If the former, I suggest the patch is altered to leave fd with badfdops in place so that epoll users get less surprised. -- Mateusz Guzik