From owner-freebsd-ports@FreeBSD.ORG  Tue Nov 28 19:58:13 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B9C1716A47C
	for <freebsd-ports@freebsd.org>; Tue, 28 Nov 2006 19:58:13 +0000 (UTC)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [204.127.192.82])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0735743E3D
	for <freebsd-ports@freebsd.org>; Tue, 28 Nov 2006 19:52:46 +0000 (GMT)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from icarus.home.lan
	(c-67-174-220-97.hsd1.ca.comcast.net[67.174.220.97])
	by comcast.net (rwcrmhc12) with ESMTP
	id <20061128195249m1200e17ege>; Tue, 28 Nov 2006 19:52:49 +0000
Received: by icarus.home.lan (Postfix, from userid 1000)
	id 7FAC21FA01D; Tue, 28 Nov 2006 11:52:49 -0800 (PST)
Date: Tue, 28 Nov 2006 11:52:49 -0800
From: Jeremy Chadwick <koitsu@FreeBSD.org>
To: Jeremy Messenger <mezz7@cox.net>
Message-ID: <20061128195249.GA89593@icarus.home.lan>
Mail-Followup-To: Jeremy Messenger <mezz7@cox.net>,
	Anthony Elizondo <anthony.elizondo@gmail.com>, riggs@rrr.de,
	freebsd-ports@freebsd.org
References: <a49e62c80611281022o5cf13eaqbb7213e57ac29103@mail.gmail.com>
	<op.tjqp7ush9aq2h7@mezz.mezzweb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <op.tjqp7ush9aq2h7@mezz.mezzweb.com>
X-PGP-Key: http://jdc.parodius.com/pubkey.asc
User-Agent: Mutt/1.5.13 (2006-08-11)
Cc: Anthony Elizondo <anthony.elizondo@gmail.com>, riggs@rrr.de,
	freebsd-ports@freebsd.org
Subject: Re: Undefined reference to 'llrint' when portinstalling
	multimedia/mplayer
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2006 19:58:13 -0000

On Tue, Nov 28, 2006 at 01:10:32PM -0600, Jeremy Messenger wrote:
> On Tue, 28 Nov 2006 12:22:41 -0600, Anthony Elizondo  
> <anthony.elizondo@gmail.com> wrote:
> 
> >I'm getting the following error when installing multimedia/mplayer.
> >Anyone have any ideas?
> >
> >I'm running 5.3-RELEASE.
> 
> Your system is too old, please update it to 5.5 or even better to 6.x.
> 
> >libavcodec/libavcodec.a(mpegaudiodec.o)(.text+0x9a5): In function  
> >`decode_init':
> >: undefined reference to `llrint'
> 
> The llrint() was added in FreeBSD 5.4.

The port should be changed to address this fact, because the
end-user won't know what release has what libm functions until
it's too late (case in point).  For OSVERSION values:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/freebsd-versions.html

Something like this should do just fine:

.if ${OSVERSION} < 504000
BROKEN=		Requires FreeBSD 5.4 or later, for llrint(3)
.endif

-- 
| Jeremy Chadwick                                 jdc at parodius.com |
| Parodius Networking                        http://www.parodius.com/ |
| UNIX Systems Administrator                   Mountain View, CA, USA |
| Making life hard for others since 1977.               PGP: 4BD6C0CB |