From nobody Fri Jan 30 17:20:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f2jSw3k89z6QBMy for ; Fri, 30 Jan 2026 17:20:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f2jSw2wqRz47R8 for ; Fri, 30 Jan 2026 17:20:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769793632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bN9q578O5YbuMtJYY0uc6RJbpAo8fBB7w2JQTdPC/9A=; b=he8xABiR9+orvBd01+it/+0cq4ESyfxtmNaAGiTQ4OnNCaOWJWJB8/Q5EHGa2NapSTxPWz IWw/X9N/YXsvhKeAWOcxX/PC+PXiyUiMsc62i3r6IxibJer2pZ7RpuzlxsktBI7PweVHMw Ih8FCVTdCLhlLQTT+7BZy+IeaqizjXlYdCaKfInKz41TL6wAazWHNsgFycSI53YsGaWxON AmdgUhrTVYTZSCjB5raBq3X8IVTVR9PZkBRZ4VMp3Gv4enKKZ6UCTo8my7ot4ZfUzHdZJ9 WWYfg1gTwVCesUpzWooPoPm3MhyFCrBQMxkRj0uPR777AWb6odKmHHKeTk/R+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769793632; a=rsa-sha256; cv=none; b=N8sCssiO1sEsFtdZ6oCuIiCuE3mb2sm1BIanZau+xTAs6REOWFB8iLlswJ7vk2sFm7Qni1 IR/T0RPxZZ74/GhJwtHs7JiRSbcdpRASfJu1Y4hyEGCOsp1LC7WLuUvMZXvPex7qf1S5UD I9rRJHarK6KG73S5lYgBI8pvm4OCYMdAS1QEfCrvtb5P3K+v1Gy550yoRRB9Us8tk95agW 0xTHCgHfs7K1de6FLbNubTDth9NMeNd03MDmGYwP8XdeRssSIQ9NQD3o4nrei4mk1/L/yW WPA64Glw7Zs8arUZpGhfBMot9f42EfseKbEQcqfRFT/4Q4OKQekefWaIEBboGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769793632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bN9q578O5YbuMtJYY0uc6RJbpAo8fBB7w2JQTdPC/9A=; b=hpW8H139LfF/06kiAqm0r3Ysud29FEHP1tM4cP87Pd5N5jJ4oJXJTX+jurINOmajMj5Giq 3/Hyh/fhsElq8PMakXoi5oMocRI6jmu4DrJuggOk2rt5rp6yVuOOWpL56Tno2ekIeGVTiH /S01oUeR9YLY3PK9gKpsR421zc6C2HStCECOvFmeQ9xzx/ccNW1jx494L4vWXmuslJfuuM Lb+RkQH2Dk211+CqM4LL6NvG2DcG3olp3aUfX7V9DStARJ+udnRnFvXxWdDC2hPzrJu3P6 QX2DY3UvNTat81ClTgDqsWOBHmmU56BJ0HAXRktLZzyKy2gdRw68ijbL7gDkpw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f2jSw1d3hz1dl for ; Fri, 30 Jan 2026 17:20:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 423f3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Jan 2026 17:20:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Andy Carrel From: Andrew Turner Subject: git: 93d3ac1daa0e - main - arm64: Fix kernel panic in get_arm64_sve during core dump List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 93d3ac1daa0ef3ac54ffcd5cc64a14638d04bd60 Auto-Submitted: auto-generated Date: Fri, 30 Jan 2026 17:20:32 +0000 Message-Id: <697ce860.423f3.2554b37d@gitrepo.freebsd.org> The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=93d3ac1daa0ef3ac54ffcd5cc64a14638d04bd60 commit 93d3ac1daa0ef3ac54ffcd5cc64a14638d04bd60 Author: Andy Carrel AuthorDate: 2026-01-05 07:50:27 +0000 Commit: Andrew Turner CommitDate: 2026-01-30 17:01:49 +0000 arm64: Fix kernel panic in get_arm64_sve during core dump The coredump logic calls get_arm64_sve twice: once to get the note size, and once to get the data. The note size calculation depended on the volatile `PCB_FP_SVEVALID` flag. If this flag was cleared between the two calls (e.g., due to a context switch clearing the flag to comply with the ABI), the second call would expect a smaller buffer size than the first, triggering a KASSERT panic ("invalid size"). Fix this by ensuring the SVE state is saved to the PCB before we decide whether to use SVE or VFP. PR: 292195 Reviewed by: andrew Differential Revision: https://reviews.freebsd.org/D54532 --- sys/arm64/arm64/vfp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/arm64/arm64/vfp.c b/sys/arm64/arm64/vfp.c index bcddebfaf66e..64f13458e2d9 100644 --- a/sys/arm64/arm64/vfp.c +++ b/sys/arm64/arm64/vfp.c @@ -934,6 +934,9 @@ get_arm64_sve(struct regset *rs, struct thread *td, void *buf, pcb = td->td_pcb; + if (td == curthread && (pcb->pcb_fpflags & PCB_FP_STARTED) != 0) + vfp_save_state(td, pcb); + /* If there is no SVE support in HW then we don't support NT_ARM_SVE */ if (pcb->pcb_sve_len == 0) return (false); @@ -955,9 +958,6 @@ get_arm64_sve(struct regset *rs, struct thread *td, void *buf, KASSERT(*sizep == sizeof(struct svereg_header) + buf_size, ("%s: invalid size", __func__)); - if (td == curthread && (pcb->pcb_fpflags & PCB_FP_STARTED) != 0) - vfp_save_state(td, pcb); - header = buf; memset(header, 0, sizeof(*header));