From owner-cvs-all Sun Feb 25 2: 9:58 2001 Delivered-To: cvs-all@freebsd.org Received: from moby.geekhouse.net (moby.geekhouse.net [64.81.6.36]) by hub.freebsd.org (Postfix) with ESMTP id 92BE637B4EC; Sun, 25 Feb 2001 02:09:53 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@dhcp152.geekhouse.net [192.168.1.152]) by moby.geekhouse.net (8.11.0/8.9.3) with ESMTP id f1PA9w183635; Sun, 25 Feb 2001 02:09:58 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Sun, 25 Feb 2001 02:09:33 -0800 (PST) From: John Baldwin To: Bruce Evans Subject: Re: cvs commit: src/sys/i386/conf NOTES src/sys/conf options Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 25-Feb-01 Bruce Evans wrote: > On Sat, 24 Feb 2001, John Baldwin wrote: > >> jhb 2001/02/24 11:03:19 PST >> >> Modified files: >> sys/i386/conf NOTES >> sys/conf options >> Log: >> Add back in INVARIANT_SUPPORT and expand the comments in NOTES about it >> to include the reasoning Eivind justifiably thwapped me over the head >> with. > > Now removing INVARIANT_SUPPORT is back on my todo list :-]. It enables > a whole 28 lines of code (the _mtx_assert() function). It seems to > be normal for INVARIANTS support code to be this small, so I think it > should be unconditional. You got thwapped because _mtx_assert() was > conditional on the wrong option. The smallness may have something to > do with large support code being put under other options, e.g., KTR. I think Eivind's point was that you may want to just have support for invariants in your kernel and then build a kernel module that you are debugging with invariants. For example, if I wanted to debug a device driver that used mutexes, I might build it with INVARIANTS so that the mtx_assert()'s do something useful. However, I may not wish to turn on INVARIANTS in my base kernel for some reason, and I can get by by building a kernel with just INVARIANT_SUPPORT compiled in.. > Bruce -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message