From owner-svn-src-all@freebsd.org Fri Nov 8 18:26:27 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A4F915AC25; Fri, 8 Nov 2019 18:26:27 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 478pcz1d8Yz3F85; Fri, 8 Nov 2019 18:26:26 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id xA8IQI5i021143; Fri, 8 Nov 2019 10:26:18 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id xA8IQIUn021142; Fri, 8 Nov 2019 10:26:18 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201911081826.xA8IQIUn021142@gndrsh.dnsmgr.net> Subject: Re: svn commit: r350089 - head In-Reply-To: <20191108151541.GU5599@FreeBSD.org> To: Glen Barber Date: Fri, 8 Nov 2019 10:26:18 -0800 (PST) CC: Mark Johnston , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 478pcz1d8Yz3F85 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 18:26:27 -0000 > On Wed, Jul 17, 2019 at 07:09:06PM +0000, Mark Johnston wrote: > > Author: markj > > Date: Wed Jul 17 19:09:05 2019 > > New Revision: 350089 > > URL: https://svnweb.freebsd.org/changeset/base/350089 > > > > Log: > > Add an initial RELNOTES file. > > > > The intent is to provide a convenient location to document changes > > that are relevant to users of binary FreeBSD distributions, in contrast > > with UPDATING, which exists to document caveats for users who build > > FreeBSD from source. > > > > This complements the "Relnotes:" tag in commit messages by providing a > > place to document the change in more detail, or in case a "Relnotes:" > > tag was accidentally omitted. In particular, "Relnotes:" should be > > used if you do not intend to document the change in RELNOTES for some > > reason. > > > > Changes to the file should not be MFCed. For now the file will exist > > only in head, but may be updated via direct commits to stable branches > > depending on how things go. > > > > I had to go look at the original thread to remind myself about this, but > regarding not MFCing changes from head to stable branches, I think there > may have been some confusion in the discussion. > > By "changes should not be MFCed", at least based on my recollection of > how the conversation was going, I (at least) meant "not MFCed, but > committed as a direct commit to stable branches." In other words, > merging the RELNOTES change from head to stable/X does not really make > sense, as the revision numbers will have changed, and would inevitably > cause merge conflicts. > > Now that 12.1 is out, maybe we can expand the idea of this file into > stable/12 and even stable/11. One additional idea that came to mind is > with the formatting for stable branches. > > For example, in head, there is: > > rNNNNNN: > The foo(8) utility was added. > > For stable branches, I would propose the format of: > > rNNNNNM, MFC of rNNNNNN: > The foo(8) utility was added. > > Thoughts? My thoughs originally on this was that when a release noteable item is merged from head to stable the exact related commit to RELNOTES should also be merged unaltered. The RELNOTES file should state that revision numbers in this file are ^/HEAD revision numbers, and that a merge serach may be needed to find the branch verson of the MFC. The ^/head RELNOTES file should be trunkated to length 0 when a .0 branch is crated POST branch creation, thus all the relevant entries are in the file on the new branch and can grow as things are merged to it. Thus keeps the RELNOTES file in a state that matches the branch as far as entires, just the Rxxxxx is referential to when the entry was created relative to head. > Glen -- Rod Grimes rgrimes@freebsd.org