From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 14 13:44:38 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 837D9106564A; Wed, 14 Mar 2012 13:44:38 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2]) by mx1.freebsd.org (Postfix) with ESMTP id 08AD78FC12; Wed, 14 Mar 2012 13:44:37 +0000 (UTC) Received: from mail3.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id q2EDiUxl013130; Wed, 14 Mar 2012 14:44:30 +0100 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130]) by mail3.siemens.de (8.13.6/8.13.6) with ESMTP id q2EDiUxN025561; Wed, 14 Mar 2012 14:44:30 +0100 Received: (from localhost) by curry.mchp.siemens.de (8.14.5/8.14.5) id q2EDiU01086714; Date: Wed, 14 Mar 2012 14:44:30 +0100 From: Andre Albsmeier To: Adrian Chadd Message-ID: <20120314134430.GA36213@bali> References: <20120312151358.GA26109@bali> <20120313111126.GA29538@bali> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Echelon: X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "freebsd-wireless@freebsd.org" , "Albsmeier, Andre" , "freebsd-mobile@freebsd.org" Subject: Re: [Patch] Reflect state of rfkill switch in a sysctl for ath based card X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2012 13:44:38 -0000 On Tue, 13-Mar-2012 at 18:30:04 +0100, Adrian Chadd wrote: > On 13 March 2012 04:11, Andre Albsmeier wrote: > > >> Would you please create a PR and let me know what the PR number is? > > > > Well, there is a high probability that it might not work on > > non-5212 cards end even here it might fail (I can just test > > it with this Wistron CM9 card). Maybe someone with more > > knowledge about ath(4) (Sam?) might have quick look at it > > before... > > Oh, I'm the ath(4) maintainer now and I'm pretty cluey in this area. Ah, I didn't know that. I hope you didn't refer my statement about "someone with more knowledge about ath" to you -- it was just meant to express my poor overall knowledge of this driver ;-) > > The AR5416 and later NICs have a similar looking GPIO rfkill setup but > the code isn't yet in the FreeBSD HAL. > I have it though, I just haven't ported it from the Atheros reference driver. > > I'd prefer the rfkill method to be a HAL call, rather than assuming > it's a GPIO line. (I mean, it _is_ a GPIO line, but still.) In any I although thought about making it a HALL call but I first wanted to make sure it works at all. And so it stayed like this ;-) > case, please create a PR for it now and we'll get it into -HEAD once OK: kern/166086 > I've merged in rfkill support for the AR5416 and later NICs. > > Thanks, > > Adrian > (I work at Atheros now, so..) That's good news! -Andre