Date: Fri, 14 Oct 2022 17:01:46 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: cf75f452e94a - main - sysutils/conky: Update to 1.14.0 Message-ID: <934dc4ad-91df-2376-63e7-b82be53ecdb2@FreeBSD.org> In-Reply-To: <Y0l40iZP2cVzRQ/8@xombo.localdomain> References: <202210131824.29DIO985022530@gitrepo.freebsd.org> <Y0l40iZP2cVzRQ/8@xombo.localdomain>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/10/22 16:57, Dmitri Goutnik wrote: > Hi, > > On 22-10-13 18:24:09, Guido Falsi wrote: >> The branch main has been updated by madpilot: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=cf75f452e94a2eb6da98eabc5b9e002f138e4051 >> >> commit cf75f452e94a2eb6da98eabc5b9e002f138e4051 >> Author: Guido Falsi <madpilot@FreeBSD.org> >> AuthorDate: 2022-10-13 18:22:58 +0000 >> Commit: Guido Falsi <madpilot@FreeBSD.org> >> CommitDate: 2022-10-13 18:22:58 +0000 >> >> sysutils/conky: Update to 1.14.0 >> >> - Add patch implementing missing function for FreeBSD, already >> proposed upstream: https://github.com/brndnmtthws/conky/pull/1252 >> >> - Updated dependencies, upstream changed its documentation build >> method >> >> Old html documentation has been removed, the information is now >> encoded in yaml files. >> >> Upstream code does not provide a method to automatically produce >> human readable documentation from the yaml files, so I install those >> directly in PORTDOCS. >> --- >> sysutils/conky/Makefile | 24 +++++++++--------- >> sysutils/conky/distinfo | 6 ++--- >> sysutils/conky/files/patch-CMakeLists.txt | 18 +++----------- >> sysutils/conky/files/patch-doc_CMakeLists.txt | 11 +++++++++ >> sysutils/conky/files/patch-doc_docgen.sh | 13 ---------- >> sysutils/conky/files/patch-src_display-console.cc | 16 ------------ >> sysutils/conky/files/patch-src_freebsd.cc | 30 +++++++++++++++++++++++ >> 7 files changed, 61 insertions(+), 57 deletions(-) >> >> diff --git a/sysutils/conky/Makefile b/sysutils/conky/Makefile >> index 8921bf37c4b5..74c9a4df4102 100644 >> --- a/sysutils/conky/Makefile >> +++ b/sysutils/conky/Makefile >> @@ -1,5 +1,5 @@ >> PORTNAME= conky >> -PORTVERSION= 1.13.1 >> +PORTVERSION= 1.14.0 >> DISTVERSIONPREFIX= v >> CATEGORIES= sysutils >> >> @@ -8,13 +8,13 @@ COMMENT?= Advanced, highly configurable system monitor for X11 >> WWW= https://github.com/brndnmtthws/conky >> >> LIB_DEPENDS= libinotify.so:devel/libinotify >> -BUILD_DEPENDS= db2x_xsltproc:textproc/docbook2X \ >> - docbook-xsl>=0:textproc/docbook-xsl \ >> - xsltproc:textproc/libxslt \ >> - gsed:textproc/gsed >> +BUILD_DEPENDS= gsed:textproc/gsed \ >> + pandoc:textproc/hs-pandoc \ >> + ${PYTHON_PKGNAMEPREFIX}yaml>0:devel/py-yaml@${PY_FLAVOR} \ >> + ${PYTHON_PKGNAMEPREFIX}Jinja2>=0:devel/py-Jinja2@${PY_FLAVOR} > > Can we make installing pandoc and other doc building machinery depend on DOCS > knob? Bulding ghc takes a long time and it's just a cycle wastage if docs > aren't going to be installed anyway. Actually pandoc is used to build the man page, so, no, it is an unconditional requirement, since the man page is not considered part of DOCS, but an essential part. I Could hack something to wrap building the man page in a knob, but I would not like to install the package without a man page by default anyway. Also, this is happening more and more. I think it is a lost battle. The rest of the world builds things using CI environments and similar things, and does not care for heavy dependencies, since it's not their problem to build them. We will see projects pulling in unconditional heavy dependencies with increasing frequency in the future (see rust, for the most evident example). Fighting it in the ports tree is wasted energy in my opinion -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?934dc4ad-91df-2376-63e7-b82be53ecdb2>