Date: Sat, 15 Jan 2005 12:16:33 +0100 From: Dejan Lesjak <dejan.lesjak@ijs.si> To: freebsd-x11@freebsd.org Cc: freebsd-ports@freebsd.org Subject: Re: [PATCH] X.org/XFree86 DEPENDS_TARGET Message-ID: <200501151216.33792.dejan.lesjak@ijs.si> In-Reply-To: <20050104093017.GA1048@straylight.m.ringlet.net> References: <20050104092619.GA787@straylight.m.ringlet.net> <20050104093017.GA1048@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 04 of January 2005 10:30, Peter Pentchev wrote:
> On Tue, Jan 04, 2005 at 11:26:19AM +0200, Peter Pentchev wrote:
> > Hi,
> >
> > Maybe I should have spoken up earlier, since I've been running with
> > this little patch for pretty much a year now, but still, better late
> > than never, I guess :)
>
> Whoops. I certainly meant to CC this to -ports.
>
> > Currently, both x11/xorg and x11/XFree86-4 redefine the DEPENDS_TARGET
> > when a package is requested. What do y'all think about the following
> > trivial patch that makes it only override DEPENDS_TARGET if it does not
> > already contain a 'package' target? I always build all ports with a
> > DEPENDS_TARGET='install package clean', which helps a lot, especially
> > with the X.org/XFree86 metaports ;)
[snip]
> > -.if make(package)
> > +.if make(package) && ${DEPENDS_TARGET:Mpackage} == ""
This doesn't seem to work if DEPENDS_TARGET is not defined, the following line
however does:
.if make(package) && empty(${DEPENDS_TARGET:Mpackage})
Does this still work in your case as expected?
Dejan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501151216.33792.dejan.lesjak>