From owner-cvs-all@FreeBSD.ORG Sat Mar 13 09:50:51 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3369F16A4CE; Sat, 13 Mar 2004 09:50:51 -0800 (PST) Received: from orange.csi.cam.ac.uk (orange.csi.cam.ac.uk [131.111.8.77]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFC9143D5A; Sat, 13 Mar 2004 09:50:50 -0800 (PST) (envelope-from fanf2@hermes.cam.ac.uk) Received: from fanf2 (helo=localhost) by orange.csi.cam.ac.uk with local-esmtp (Exim 4.12) id 1B2DHe-00074Q-00; Sat, 13 Mar 2004 17:50:50 +0000 Date: Sat, 13 Mar 2004 17:50:50 +0000 (GMT) From: Tony Finch X-X-Sender: fanf2@orange.csi.cam.ac.uk To: Ruslan Ermilov In-Reply-To: <20040312223315.GE4588@ip.net.ua> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: Tony Finch cc: Tom Rhodes cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/arc/include arcfuncs.hsrc/sys/boot/i386/boot2 boot2.c src/sys/dev/aic7xxx/aicasm aicasm.c src/sys/dev/cx machdep.h src/sys/dev/ichsmb ichsmb.c src/sys/dev/iir iir.h src/s X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2004 17:50:51 -0000 On Sat, 13 Mar 2004, Ruslan Ermilov wrote: > On Fri, Mar 12, 2004 at 01:45:45PM -0800, Tom Rhodes wrote: > > > > -#ifdef __GNUC__ > > -#if __GNUC__ >= 2 > > +#if defined(__GNUC__) || defined(__INTEL_COMPILER) > > +#if __GNUC__ >= 2 || defined(__INTEL_COMPILER) > > #pragma pack(4) > > #endif > > #endif > > These ifdefs are broken. > > #if (defined(__GNUC__) && __GNUC >= 2) || defined(__INTEL_COMPILER) > > would be more correct. Why, given that an undefined macro is equivalent to 0 in this context? -- Tony Finch http://dotat.at/