From owner-freebsd-bugs Sat May 13 5: 0:24 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 2F4AC37BDF9 for ; Sat, 13 May 2000 05:00:14 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id FAA52358; Sat, 13 May 2000 05:00:13 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Sat, 13 May 2000 05:00:13 -0700 (PDT) Message-Id: <200005131200.FAA52358@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: John Baldwin Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf Reply-To: John Baldwin Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/18498; it has been noted by GNATS. From: John Baldwin To: Jeroen Ruigrok/Asmodai Cc: FreeBSD-gnats-submit@FreeBSD.org, mellon@pobox.com Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf Date: Sat, 13 May 2000 08:00:03 -0400 (EDT) On 13-May-00 Jeroen Ruigrok/Asmodai wrote: > -On [20000511 16:02], mellon@pobox.com (mellon@pobox.com) wrote: >> >>5.0-CURRENT >> >>>Description: >> >>For debugging the loader, the following trivial change to >>src/sys/boot/common/Makefile.inc will allow placing ELF_VERBOSE=true >>in /etc/make.conf instead of having to change the makefile; this >>makes life a little bit brighter and is exactly the arrangement >>already existing with BTXLDR_VERBOSE in sys/boot/i386/btx/btxldr/Makefile, >>for instance. >> >>>How-To-Repeat: >> >>>Fix: >> >>Index: Makefile.inc >>=================================================================== >>RCS file: /freebsd/cvs/src/sys/boot/common/Makefile.inc,v >>retrieving revision 1.9 >>diff -u -r1.9 Makefile.inc >>--- Makefile.inc 1999/08/28 00:39:44 1.9 >>+++ Makefile.inc 2000/05/11 15:53:43 >>@@ -16,3 +16,9 @@ >> .if BOOT_FORTH >> SRCS+= interp_forth.c >> .endif >>+ >>+.if defined(ELF_VERBOSE) >>+CFLAGS+=-DELF_VERBOSE >>+.endif >>+ >>+ > > Why those two trailing newlines? They don't have to be in the final commit. :) > Anyways, John, what do you think of this change? > > I think it would make debugging easier for those who want it, however > the ELF_VERBOSE name is a tad bit generic to make it a make.conf > variable. I prefer it to be ELF_BOOT_VERBOSE or something like that. > Or ELF_BOOT_DEBUG. Probably BOOT_ELF_{DEBUG,VERBOSE} and with some tweaks we could make it so that all boot variables start with BOOT_, that way we can avoid nameclashes, and indicate that it is a variable that applies only to BOOT related stuff. > Just my interpretation to get this integrated. > > -- > Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] > Documentation nutter/C-rated Coder BSD: Technical excellence at its best > The BSD Programmer's Documentation Project > Sleep tonight, sweet summer light, scattered yesterdays, the past is far > away... -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message