From owner-freebsd-current@FreeBSD.ORG  Wed Oct 21 23:41:52 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3D98A1065676;
	Wed, 21 Oct 2009 23:41:52 +0000 (UTC)
	(envelope-from qing.li@bluecoat.com)
Received: from whisker.bluecoat.com (whisker.bluecoat.com [216.52.23.28])
	by mx1.freebsd.org (Postfix) with ESMTP id 20C938FC12;
	Wed, 21 Oct 2009 23:41:51 +0000 (UTC)
Received: from bcs-mail03.internal.cacheflow.com ([10.2.2.95])
	by whisker.bluecoat.com (8.14.2/8.14.2) with ESMTP id n9LNfpMS027391;
	Wed, 21 Oct 2009 16:41:51 -0700 (PDT)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 21 Oct 2009 16:41:46 -0700
Message-ID: <B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com>
In-Reply-To: <9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: svn commit: r198306 - head/sys/net
Thread-Index: AcpSBgWAgxSIOAFgSy+5n/0aIH9hkgAoNaEQ
References: <d873d5be0910201621h768e126dq34df38c07b83fe47@mail.gmail.com><bc2d970910201734o332582ceic30fb7e42e14c812@mail.gmail.com><d873d5be0910201900w67833e83kf53b556e2b5c8d00@mail.gmail.com><bc2d970910202030u2c03571etb6379cf29260617d@mail.gmail.com>
	<9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com>
From: "Li, Qing" <qing.li@bluecoat.com>
To: "Qing Li" <qingli@freebsd.org>, "Ryan Stone" <rysto32@gmail.com>
Cc: freebsd-current@freebsd.org, "b. f." <bf1783@googlemail.com>
Subject: RE: svn commit: r198306 - head/sys/net
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2009 23:41:52 -0000

I reviewed the SMP code and architecture modules last night. After =
discussion=20
with Kip Macy, we feel using the "#ifdef SMP" is actually not necessary=20
here.=20

There is one more function in the flow-table module needs to check for =
the=20
smp_started condition, but other than that, I don't intend to fix =
anything=20
else at this point.

-- Qing

>=20
> b.f.,
>=20
> I think you are right in saying those code blocks should
> have "#ifdef SMP" condition around them. I am in the
> process of make those changes.
>=20
> Thanks,
>=20
> -- Qing
>=20
> On Tue, Oct 20, 2009 at 8:30 PM, Ryan Stone <rysto32@gmail.com> wrote:
> > Judging from the checkin comment, it is not intended to only
> eliminate
> > the call to sched_bind in the non-SMP case. =A0However. you asked
> > whether it would work correctly in the non-SMP case and I answered
> > that question.
> >
> > Ryan
> >
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-
> unsubscribe@freebsd.org"