From owner-freebsd-hackers@FreeBSD.ORG Fri Oct 23 12:08:53 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A4E8106566B for ; Fri, 23 Oct 2009 12:08:53 +0000 (UTC) (envelope-from a_best01@uni-muenster.de) Received: from zivm-exrelay3.uni-muenster.de (ZIVM-EXRELAY3.UNI-MUENSTER.DE [128.176.192.20]) by mx1.freebsd.org (Postfix) with ESMTP id C0EF98FC21 for ; Fri, 23 Oct 2009 12:08:52 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.44,612,1249250400"; d="scan'208";a="16604498" Received: from zivmaildisp1.uni-muenster.de (HELO ZIVMAILUSER04.UNI-MUENSTER.DE) ([128.176.188.85]) by zivm-relay3.uni-muenster.de with ESMTP; 23 Oct 2009 14:08:51 +0200 Received: by ZIVMAILUSER04.UNI-MUENSTER.DE (Postfix, from userid 149459) id 15E401B07BD; Fri, 23 Oct 2009 14:08:51 +0200 (CEST) Date: Fri, 23 Oct 2009 14:08:50 +0200 (CEST) From: Alexander Best Sender: Organization: Westfaelische Wilhelms-Universitaet Muenster To: , pluknet Message-ID: In-Reply-To: <20091023135024.377bcfa6@ernst.jennejohn.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Antony Mawer , freebsd-hackers@freebsd.org Subject: Re: help needed to fix contrib/ee crash/exit when receiving SIGWINCH X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2009 12:08:53 -0000 Gary Jennejohn schrieb am 2009-10-23: > On Fri, 23 Oct 2009 12:58:43 +0400 > pluknet wrote: > > 2009/10/23 Antony Mawer : > > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best > > > wrote: > > >> hi everyone, > > >> together with hugh mahon (the author of ee) i've been trying to > > >> fix a nasty > > >> bug in ee. for some reason ee exits (not crashes) and leaves the > > >> console > > >> corrupted when receiving SIGWINCH (`killall -SIGWINCH ee` should > > >> exit all > > >> running ee instances). > > > I noticed this the other day when working on a new 8.0-RC1 > > > system... > > > in my case I was using putty (Windows ssh client) to access the > > > system > > > and maximised the window I had ee running in, and noticed ee just > > > dumped me straight to the prompt. > > > I am wondering if this has anything to do with the new tty > > > subsystem > > > in 8.0, as this wasn't a problem I've experienced before under > > > 7.x... > > No, that's a regression appeared in (FreeBSD'ish? version of) ee > > 1.5.0. > SIGWINCH is handled in new_curse.c, but it's not being > compiled/linked. > --- > Gary Jennejohn i think that file is only used on systems which have termio.h/sgtty.h and ee doesn't get linked against ncurses. on those systems (linux e.g.) new_curse.c is used to handle certain things which ncurses takes care under freebsd. this is under freebsd: `make`: Neither termio.h or sgtty.h are on this system! Relying on local curses implementation. Generating make.local make -f make.local cc ee.c -o ee -ggdb -DDIAG -DHAS_UNISTD -DHAS_STDARG -DHAS_STDLIB -DHAS_CTYPE -DHAS_SYS_IOCTL -DHAS_SYS_WAIT -DSLCT_HDR -DTERMCAP="\"/usr/share/misc/termcap\"" -lcursesw `ldd ee`: libncursesw.so.8 => /lib/libncursesw.so.8 (0x2809b000) libc.so.7 => /lib/libc.so.7 (0x280e9000) and under linux: `make`: Generating make.local make -f make.local make[1]: Entering directory `/easyedit-test' cc -c ee.c -DSYS5 -DBSD_SELECT -DNCURSE -DHAS_UNISTD -DHAS_STDLIB -DHAS_CTYPE -DHAS_SYS_IOCTL -DHAS_SYS_WAIT -DSLCT_HDR -s cc new_curse.c -c -DSYS5 -DBSD_SELECT -DNCURSE -DHAS_UNISTD -DHAS_STDLIB -DHAS_CTYPE -DHAS_SYS_IOCTL -DHAS_SYS_WAIT -DSLCT_HDR -s cc -o ee ee.o new_curse.o -DHAS_UNISTD -DHAS_STDLIB -DHAS_CTYPE -DHAS_SYS_IOCTL -DHAS_SYS_WAIT -DSLCT_HDR -s make[1]: Leaving directory `/easyedit-test' `ldd ee`: libc.so.6 => /lib/libc.so.6 (0x2807a000) /lib/ld-linux.so.2 (0x2805b000) alex