From owner-freebsd-current@FreeBSD.ORG Sun Jun 28 16:55:56 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BBB61065688; Sun, 28 Jun 2009 16:55:56 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by mx1.freebsd.org (Postfix) with ESMTP id 0B72C8FC0A; Sun, 28 Jun 2009 16:55:55 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by wa-out-1112.google.com with SMTP id m38so960981waf.27 for ; Sun, 28 Jun 2009 09:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=iZ3hBa34nWz0MCBO4dtgiybijBDXLJXr8Eeb9mRFBwc=; b=Ep/QFHiac9+3jLQNHUJJXZvZwKJyKFa6kHxKnPA6rkDB2/8lpjLowbc1btf5qcOFeX 4W+qqWM0iWfCT6p52wEk+gG0Yk2J4fBeqIJjApn+vW60aQNY0qm36Vg7QResGiTT7Wq2 3NUbhvgKrBW1wekk2HrAbtSKXCp1mRVjO/PC4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Hq/Y7c69OedRb4EinDvxz47mf8Rh6AlKww8jQ0eSrYprYz6If6cePCTyhU4OOumSb5 qjMsdPXWAGop8buephQ9U0pykz3r1Jco5+s+UddEezerhOa6WOufXbuzfTZKU9jW2MKJ PWEjyP7RJd23Oa4yE2FubRLrcl8aSo0vd/vfM= MIME-Version: 1.0 Received: by 10.114.185.12 with SMTP id i12mr9864791waf.123.1246207726547; Sun, 28 Jun 2009 09:48:46 -0700 (PDT) In-Reply-To: References: <200906241741.n5OHfTaw022417@svn.freebsd.org> <4A43893F.5070100@andric.com> <24BDCB76-0304-443A-96A9-71C5E537FF37@exscape.org> Date: Sun, 28 Jun 2009 09:48:46 -0700 Message-ID: <2a41acea0906280948x34d64510v23b17c75d9fac0b@mail.gmail.com> From: Jack Vogel To: Robert Watson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jack F Vogel , Dimitry Andric , current@freebsd.org, Thomas Backman Subject: Re: VMWare if_em breakage (was: Re: svn commit: r194865 - in head/sys: dev/e1000 modules/igb) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2009 16:55:56 -0000 Yes, thanks Robert. I was planning on submitting this on Monday. Talk about a annoying little bug :) Jack On Sun, Jun 28, 2009 at 6:04 AM, Robert Watson wrote: > > On Sun, 28 Jun 2009, Thomas Backman wrote: > > On Jun 25, 2009, at 04:27 PM, Dimitry Andric wrote: >> >> On 2009-06-25 16:08, Robert Watson wrote: >>> >>>> Since this change (and the two followups), I'm no longer able to use >>>> if_em reliable in VMWare Fusion. >>>> >>> >>> Same here, for VMware Workstation. The interface just stops working >>> after a bit of traffic. >>> >> >> Not sure it's needed, but here's another "me too", also using Fusion. At >> first I thought it had frozen, but locally, in the VM window, everything >> worked fine. (I always interact with VMs via SSH to get copy/paste, better >> fonts etc). Also worth mentioning is that vmware-vmx ate 100% real CPU the >> entire time, despite the VM CPU (top in FreeBSD) showed 100% *idle*. >> > > Jack suggested this patch for me to test, and it seems to work here, so > hopefully he doesn't mind my sharing it until it before it gets into SVN. > It seems to entirely prevent the problem from occuring here. > > Robert N M Watson > Computer Laboratory > University of Cambridge > > Index: if_em.c > =================================================================== > --- if_em.c (revision 195108) > +++ if_em.c (working copy) > @@ -4446,7 +4446,7 @@ > struct mbuf *mp; > u8 status, accept_frame = 0, eop = 0; > u16 len, desc_len, prev_len_adj; > - u32 i, rx_sent = 0; > + int i, rx_sent = 0; > struct e1000_rx_desc *current_desc; > > EM_RX_LOCK(adapter); > >