From owner-svn-src-all@FreeBSD.ORG Fri Jul 5 16:21:44 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id EBC24EF4; Fri, 5 Jul 2013 16:21:44 +0000 (UTC) (envelope-from dteske@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id DE8571650; Fri, 5 Jul 2013 16:21:44 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r65GLiP8092852; Fri, 5 Jul 2013 16:21:44 GMT (envelope-from dteske@svn.freebsd.org) Received: (from dteske@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r65GLiNl092851; Fri, 5 Jul 2013 16:21:44 GMT (envelope-from dteske@svn.freebsd.org) Message-Id: <201307051621.r65GLiNl092851@svn.freebsd.org> From: Devin Teske Date: Fri, 5 Jul 2013 16:21:44 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r252797 - head/usr.sbin/sysrc X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jul 2013 16:21:45 -0000 Author: dteske Date: Fri Jul 5 16:21:44 2013 New Revision: 252797 URL: http://svnweb.freebsd.org/changeset/base/252797 Log: Do not inherit $SYSRC_VERBOSE from operating environment. The concern is that when a user (such as myself) which has SYSRC_VERBOSE=1 in his/her ~/.bash_profile or such that when they are told to execute a command like: hostname `sysrc -n hostname` NOTE: To activate a recently configured hostname. If $SYSRC_VERBOSE is set, then POLA is violated because the output of sysrc is indirectly influenced (making for an inconsistent experience). Modified: head/usr.sbin/sysrc/sysrc Modified: head/usr.sbin/sysrc/sysrc ============================================================================== --- head/usr.sbin/sysrc/sysrc Fri Jul 5 16:03:19 2013 (r252796) +++ head/usr.sbin/sysrc/sysrc Fri Jul 5 16:21:44 2013 (r252797) @@ -1,6 +1,6 @@ #!/bin/sh #- -# Copyright (c) 2010-2012 Devin Teske +# Copyright (c) 2010-2013 Devin Teske # All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -32,13 +32,6 @@ BSDCFG_SHARE="/usr/share/bsdconfig" [ "$_COMMON_SUBR" ] || . $BSDCFG_SHARE/common.subr || exit 1 [ "$_SYSRC_SUBR" ] || f_include $BSDCFG_SHARE/sysrc.subr -############################################################ CONFIGURATION - -# -# Default verbosity. -# -: ${SYSRC_VERBOSE:=} - ############################################################ GLOBALS # @@ -55,6 +48,7 @@ SHOW_EQUALS= SHOW_FILE= SHOW_NAME=1 SHOW_VALUE=1 +SYSRC_VERBOSE= ############################################################ FUNCTIONS