Date: Tue, 28 Jun 2016 22:44:52 +0200 From: Rodrigo OSORIO <rodrigo@freebsd.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: pkg SAT_SOLVER bugs Message-ID: <31cddde4-7c78-a1c6-042a-42b713c20ffc@freebsd.org> In-Reply-To: <20160627220942.gy7t3klnswmukz6q@ivaldir.etoilebsd.net> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <81eaaea2-edc7-9337-0b53-ff6df1c1beca@freebsd.org> <20160627220942.gy7t3klnswmukz6q@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/28/16 00:09, Baptiste Daroussin wrote: > On Mon, Jun 27, 2016 at 11:42:08PM +0200, Rodrigo OSORIO wrote: >> On 06/27/16 12:38, Hans Petter Selasky wrote: >>> Hi, >>> >>> I found some bugs in PKG with regard to the SAT_SOLVER environment >>> variable. Please find patch attached :-) >>> >>> Issues fixed: >>> 1) No need to use hash table when generating SAT rules for external >>> solver. Variables are already in a linear array. Fix encoding and >>> decoding of SAT data. >>> 2) Endless variable loop caused pkg to crash. >>> 3) it->inverse was checked for non-zero, while it should actually be >>> checked for -1 only. SAT rules produces were all negative. >>> >>> How to verify: >>> >>> make -C /usr/ports/math/picosat all install clean >>> >>> env SAT_SOLVER=picosat pkg upgrade >>> >>> --HPS >>> >>> >>> _______________________________________________ >>> freebsd-ports@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-ports >>> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" >>> >> >> Thanks! this patch saves my day, I was stuck reinstalling a computer in >> current, and after few rounds using pkg the solver start complaining and >> pretending missing packages was yet installed. >> >> I apply you patch on top of the last version in ports and the patch work as >> a charm. I'll keep testing it until a new version comes. >> >> regards, >> - rodrigo > > that is unrelated, what saved you it that building from ports you switched form > 1.8.5 to 1.8.6 his patch is to solve the use of an external SAT solver which I > admit I haven't tested for a while. > > Pkg 1.8.6 is the default binary package for all release but head right now, > pending for the next build cycle. > > Best regards, > Bapt > Ouch, that hurts but you're right ;) sorry for the unnecessary noise
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31cddde4-7c78-a1c6-042a-42b713c20ffc>