Date: Sat, 26 May 2018 16:36:51 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470615 - head Message-ID: <alpine.LSU.2.21.1805261634080.3624@anthias.pfeifer.com> In-Reply-To: <201805221358.w4MDwYtl021212@repo.freebsd.org> References: <201805221358.w4MDwYtl021212@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 22 May 2018, Mathieu Arnold wrote: > New Revision: 470615 > URL: https://svnweb.freebsd.org/changeset/ports/470615 > > Log: > Don't tell people to use @${FLAVOR} in that case, it's bad practice. I'm picking this as one example of various I've seen (from various committers, not meaning to single you out, Mathieu): When going through a commit history at a later point to look for something specific, understand the evolution of code, or to simply better understand a commit, good commit messages are paramount. The above, and unfortunately many others, do not really help much. (What is "this case"? Why is it bad practice? ...) Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1805261634080.3624>