From owner-freebsd-multimedia@freebsd.org Mon Jul 30 23:57:10 2018 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C626710649E7 for ; Mon, 30 Jul 2018 23:57:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 630108B851 for ; Mon, 30 Jul 2018 23:57:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2719310649E1; Mon, 30 Jul 2018 23:57:10 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0529310649E0 for ; Mon, 30 Jul 2018 23:57:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 849FD8B84E for ; Mon, 30 Jul 2018 23:57:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C971A809A for ; Mon, 30 Jul 2018 23:57:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6UNv8Gr014650 for ; Mon, 30 Jul 2018 23:57:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6UNv8YB014649 for multimedia@FreeBSD.org; Mon, 30 Jul 2018 23:57:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 230211] multimedia/avidemux-plugins fails to build: ISO C++ forbids comparison between pointer and integer [-fpermissive] (upstream patch) Date: Mon, 30 Jul 2018 23:57:08 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 23:57:11 -0000 Bugzilla Automation has asked freebsd-multimedia mai= ling list for maintainer-feedback: Bug 230211: multimedia/avidemux-plugins fails to build: ISO C++ forbids comparison between pointer and integer [-fpermissive] (upstream patch) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230211 --- Description --- After update GCC from 6.4 to 7.3 multimedia/avidemux-plugins fails to build with this error: > /tmp/work/usr/ports/multimedia/avidemux-plugins/work/avidemux_2.6.11/avidem= ux_p lugins/ADM_muxers/muxerMp4v2/libmp4v2/src/rtphint.cpp: In member function '= void mp4v2::impl::MP4RtpHintTrack::GetPayload(char**, uint8_t*, uint16_t*, char*= *)': > /tmp/work/usr/ports/multimedia/avidemux-plugins/work/avidemux_2.6.11/avidem= ux_p lugins/ADM_muxers/muxerMp4v2/libmp4v2/src/rtphint.cpp:342:35: error: ISO C++ forbids comparison between pointer and integer [-fpermissive] > if (pSlash !=3D '\0') { Look at code: > const char* pSlash; =E2=80=A6 > if (pSlash && ppEncodingParams) { > pSlash++; > pSlash =3D strchr(pSlash, '/'); > if (pSlash !=3D NULL) { > pSlash++; > if (pSlash !=3D '\0') { Error on this line ^^^^^^^^^^^^^^^^^^^^^^^^. Obvious it's incorrect code and most probably it have to be "if (*pSlash != =3D '\0')". > length =3D (uint32_t)strlen(pRtpMap) - (pSlash - pRtpMap); > *ppEncodingParams =3D (char *)MP4Calloc(length + 1); > strncpy(*ppEncodingParams, pSlash, length); > } > } > } In upstream this line was replaced on "if (*pSlash)", as expected. Just put file patch-avidemux__plugins_ADM__muxers_muxerMp4v2_libmp4v2_src_rtphint.cpp in multimedia/avidemux/files/ - work for me on 11.2 amd64 and i386.