From owner-freebsd-stable Tue Oct 23 23: 3: 6 2001 Delivered-To: freebsd-stable@freebsd.org Received: from smtp-1.enteract.com (smtp-1.enteract.com [207.229.143.33]) by hub.freebsd.org (Postfix) with ESMTP id 7AB4E37B409 for ; Tue, 23 Oct 2001 23:03:03 -0700 (PDT) Received: from bjorn.goddamnbastard.org (bjorn.goddamnbastard.org [216.80.6.225]) by smtp-1.enteract.com (Postfix) with SMTP id 32F166EFD for ; Wed, 24 Oct 2001 01:02:17 -0500 (CDT) Received: (qmail 3868 invoked by uid 1000); 24 Oct 2001 06:02:16 -0000 Date: Wed, 24 Oct 2001 01:02:16 -0500 From: ryan beasley To: stable@FreeBSD.org, Matthew L Creech , green@FreeBSD.org Subject: Re: sshd core dump Message-ID: <20011024010216.B509@bjorn.goddamnbastard.org> References: <3BBA7E1E.931F087D@prism.gatech.edu> <20011017205017.A9625@bjorn.goddamnbastard.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK" Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: <20011017205017.A9625@bjorn.goddamnbastard.org>; from ryanb@goddamnbastard.org on Wed, Oct 17, 2001 at 08:50:17PM -0500 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 17, 2001 at 08:50:17PM -0500, ryan beasley wrote: > Anywho, here's some information that will hopefully help some > people. If any more specifics are required, I'm up for any > assistance I could provide. Sorry for replying to myself, but I drafted this little "patch" that should take care of the segfault in session.c. After thinking about this for a bit, it probably should've been _really_ obvious to me after the first lookover ... --- src/crypto/openssh/session.c.orig Wed Oct 24 00:35:57 2001 +++ src/crypto/openssh/session.c Wed Oct 24 00:36:26 2001 @@ -1003,7 +1003,7 @@ char cmd[1024]; FILE *f =3D NULL; u_int envsize, i; - char **env; + char **env =3D NULL; extern char **environ; struct stat st; char *argv[10]; --=20 ryan beasley professional fat bastard http://www.goddamnbastard.org GPG Key ID 0x36321D13 with fingerprint 2074 CEB8 68AD 351A 85E6 98EB 09BA 36D9 3632 1D13 --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE71llnCbo22TYyHRMRAkENAKCo3sJbGaOwOaZeov8y6kBjelNdHACgm3VH vNCz/MRInh+wbQ016cby9to= =SZ7N -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message