From owner-freebsd-x11@freebsd.org  Fri Aug 21 12:46:10 2015
Return-Path: <owner-freebsd-x11@freebsd.org>
Delivered-To: freebsd-x11@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 680FD9BD1C3
 for <freebsd-x11@mailman.ysv.freebsd.org>;
 Fri, 21 Aug 2015 12:46:10 +0000 (UTC)
 (envelope-from matthew@reztek.cz)
Received: from mail.modirum.com (mail.modirum.com [31.185.27.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2CDFDEED
 for <freebsd-x11@freebsd.org>; Fri, 21 Aug 2015 12:46:09 +0000 (UTC)
 (envelope-from matthew@reztek.cz)
Received: from [94.142.238.108] (helo=workstation.reztek)
 by mail.modirum.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.85 (FreeBSD)) (envelope-from <matthew@reztek.cz>)
 id 1ZSlDZ-0004SC-Jj; Fri, 21 Aug 2015 12:14:45 +0000
From: Matthew Rezny <matthew@reztek.cz>
To: freebsd-x11@freebsd.org
Cc: wiz@netbsd.org
Subject: Re: FreeBSD/DragonFly patches for xf86-video-ati, xf86-input-mouse,
 and xf86-video-intel
Date: Fri, 21 Aug 2015 14:14:43 +0200
Message-ID: <5072571.Yn004kEFNN@workstation.reztek>
Organization: RezTek, s.r.o.
User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <20150817074504.GW26866@danbala.tuwien.ac.at>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
X-SA-Authenticated: Yes
X-SA-Exim-Connect-IP: 94.142.238.108
X-SA-Exim-Mail-From: matthew@reztek.cz
X-SA-Exim-Scanned: No (on mail.modirum.com); SAEximRunCond expanded to false
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11/>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2015 12:46:10 -0000

What's all that FREEBSD_USB define mess? That is significantly differen=
t than=20
what is currently in FreeBSD ports. I concur with Peter Hutterer, the c=
hanges=20
aren't OS specific. A few months ago I updated xf86-input-mouse and sim=
plified=20
some of the ifdef mess we had accumulated in patches. Please try the pa=
tches=20
currently in ports as-is with PkgSrc. They should be good to go upstrea=
m.

Michel D=E4nzer had a good point about using xf86LoadKernelModule or dr=
mOpen in=20
xf86-video-ati. We should follow convention where possible in our patch=
es.