From owner-freebsd-current Tue Nov 12 4:55:52 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4E8337B401 for ; Tue, 12 Nov 2002 04:55:50 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08E2A43E4A for ; Tue, 12 Nov 2002 04:55:49 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.6/8.12.6) with ESMTP id gACCtlmj029122; Tue, 12 Nov 2002 15:55:47 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.6/8.12.6/Submit) id gACCtlQb029121; Tue, 12 Nov 2002 15:55:47 +0300 (MSK) (envelope-from ache) Date: Tue, 12 Nov 2002 15:55:47 +0300 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: current@freebsd.org Subject: Re: sshd: double "Last login:" bugfix spammed again Message-ID: <20021112125547.GA28874@nagual.pp.ru> References: <20021106141959.GA53561@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Nov 12, 2002 at 12:37:13 +0100, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" writes: > > Old bugfix for double "Last login:" was spammed in 3rd time, causing > > following printout: > > I can't reproduce this here. Look at session.c, one "Last login" comes from print_pam_messages(); and second one comes just few lines below under if (options.print_lastlog ... condition. Now look at the times: Last login: Tue Nov 12 15:44:54 from xxx.yyy.zzz ^^^^^^^^ Last login: Tue Nov 12 15:38:01 2002 xxx.yyy.zzz The first time from print_pam_messages() is wrong in anycase, it is JUST login time, not LAST one! It clearly indicates that something wrong with print_pam_messages(). We have two ways of fix: 1) Just disable print_pam_messages() ignoring what is wrong there. 2) Fix print_pam_messages() to print right time and remove second print from sshd. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message