Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Apr 2020 21:22:44 -0400
From:      Ed Maste <emaste@freebsd.org>
To:        Piotr Kubaj <pkubaj@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r531443 - head/multimedia/obs-studio
Message-ID:  <CAPyFy2A7j=iJubt2hkhKsP33BCcwqmiS9JnYGrzbzf1Za1P6Zw@mail.gmail.com>
In-Reply-To: <202004111744.03BHicPx042080@repo.freebsd.org>
References:  <202004111744.03BHicPx042080@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 11 Apr 2020 at 13:44, Piotr Kubaj <pkubaj@freebsd.org> wrote:
>
> Author: pkubaj
> Date: Sat Apr 11 17:44:38 2020
> New Revision: 531443
> URL: https://svnweb.freebsd.org/changeset/ports/531443
>
> Log:
>   multimedia/obs-studio: fix build on powerpc64 elfv2
>
>   obs-studio uses SSE unconditionally, but Clang can't doesn't have good enough SSE -> Altivec translation layer, like GCC does:
...
> +
> +.include <bsd.port.options.mk>
> +
> +.if ${ARCH} == powerpc64
> +USES+=         compiler:gcc-c++11-lib
> +.else
> +USES+=         compiler:c++11-lib
> +.endif

I think this would benefit from a comment mentioning why it's using
GCC on powerpc64 as a hint to someone who looks at this in the future,
in case Clang gains support.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2A7j=iJubt2hkhKsP33BCcwqmiS9JnYGrzbzf1Za1P6Zw>