From owner-dev-commits-src-all@freebsd.org Sat Mar 6 09:07:07 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5687855DF6B; Sat, 6 Mar 2021 09:07:07 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DszJC10PFz3L6h; Sat, 6 Mar 2021 09:07:07 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id C235D21EB2; Sat, 6 Mar 2021 09:07:06 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 443C14B318; Sat, 6 Mar 2021 10:07:04 +0100 (CET) From: "Kristof Provost" To: "Mark Johnston" Cc: "Ryan Moeller" , "Konstantin Belousov" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c4ba4aa54718 - main - libifconfig: Overhaul ifconfig_media_* interfaces Date: Sat, 06 Mar 2021 10:07:03 +0100 X-Mailer: MailMate (1.13.2r5673) Message-ID: In-Reply-To: References: <202103051123.125BNubR059014@gitrepo.freebsd.org> <20c6efb4-8b57-ae78-3808-b49b07ac284d@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 09:07:07 -0000 On 5 Mar 2021, at 20:44, Mark Johnston wrote: > On Fri, Mar 05, 2021 at 02:40:29PM -0500, Ryan Moeller wrote: >> >> On 3/5/21 1:19 PM, Konstantin Belousov wrote: >>> On Fri, Mar 05, 2021 at 11:23:56AM +0000, Ryan Moeller wrote: >>>> The branch main has been updated by freqlabs: >>>> >>>> URL: = >>>> https://cgit.FreeBSD.org/src/commit/?id=3Dc4ba4aa547184ab401204096cd= ad9def4ab37964 >>>> >>>> commit c4ba4aa547184ab401204096cdad9def4ab37964 >>>> Author: Ryan Moeller >>>> AuthorDate: 2021-03-02 10:29:17 +0000 >>>> Commit: Ryan Moeller >>>> CommitDate: 2021-03-05 09:15:55 +0000 >>>> >>>> libifconfig: Overhaul ifconfig_media_* interfaces >>>> >>>> Define an ifmedia_t type to use for ifmedia words. >>>> >>>> Add ifconfig_media_lookup_* functions to lookup ifmedia words = >>>> by name. >>>> >>>> Get media options as an array of option names rather than = >>>> formatting it >>>> as a comma-delimited list into a buffer. >>>> >>>> Sprinkle const on static the static description tables for = >>>> peace of >>>> mind. >>>> >>>> Don't need to zero memory allocated by calloc. >>>> >>>> Reviewed by: kp >>>> MFC after: 2 weeks >>>> Differential Revision: https://reviews.freebsd.org/D29029 >>>> --- >>>> lib/libifconfig/Makefile | 2 +- >>>> lib/libifconfig/Symbol.map | 9 +- >>>> lib/libifconfig/libifconfig.h | 69 +++++++- >>>> lib/libifconfig/libifconfig_media.c | 339 = >>>> ++++++++++++++++++++++++------------ >>>> share/examples/libifconfig/status.c | 27 ++- >>>> 5 files changed, 324 insertions(+), 122 deletions(-) >>>> >>>> diff --git a/lib/libifconfig/Makefile b/lib/libifconfig/Makefile >>>> index 73dad36c1dc5..c6f006018427 100644 >>>> --- a/lib/libifconfig/Makefile >>>> +++ b/lib/libifconfig/Makefile >>>> @@ -7,7 +7,7 @@ INTERNALLIB=3D true >>>> LIBADD=3D m >>>> >>>> SHLIBDIR?=3D /lib >>>> -SHLIB_MAJOR=3D 1 >>>> +SHLIB_MAJOR=3D 2 >>>> >>>> VERSION_DEF=3D ${LIBCSRCDIR}/Versions.def >>>> SYMBOL_MAPS=3D ${.CURDIR}/Symbol.map >>> libifconfig is marked as internal, but we provide symbol versioning = >>> for it, >>> and do it in the normal FreeBSD namespace. On one hand, our policy = >>> is to >>> not bump symvered libs and to provide binary compat shims as needed, = >>> on the >>> other, this is internal lib. >>> >>> What is the purpose of maintaining symbol versions for it? >> >> >> I have work in progress that changes libifconfig to a private lib. = >> I'm >> not sure why markj@ added the symbol map, but I've been forced to >> maintain it for my later changes to work. > > I added it because there was some discussion of making it a public > library, and adding a symbol map was a step towards that. If it is = > only > going to be a private library, then there's indeed no reason to = > maintain > it. Historically it=E2=80=99s been the aspiration (passive voice, because whi= le = these have been my hopes I=E2=80=99ve not done any of the work) to make t= his a = public library, so e.g. appliance vendors could have a better way to = configure the system than doing `system(=E2=80=9Cifconfig em0 = 10.0.0.1/24=E2=80=9D);`. Libifconfig is making progress thanks to Ryan=E2=80=99s work, but it=E2=80= =99s not = yet ready for that sort of use. Given that, it makes sense to keep it as an internal library for now, = and breaking the API is fine. I still hope that we=E2=80=99ll get it to t= he = point where it=E2=80=99ll be ready for public consumption (with stable AP= I). So I think the symbol map is mostly aspirational right now. If it=E2=80=99= s a = maintenance burden I guess we can remove it, and re-add it when the time = comes. Best regards, Kristof From owner-dev-commits-src-all@freebsd.org Sat Mar 6 09:07:21 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59EAE55D9F4; Sat, 6 Mar 2021 09:07:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DszJT1rlRz3LG1; Sat, 6 Mar 2021 09:07:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2F57220E64; Sat, 6 Mar 2021 09:07:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 12697LrZ076690; Sat, 6 Mar 2021 09:07:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 12697LWC076689; Sat, 6 Mar 2021 09:07:21 GMT (envelope-from git) Date: Sat, 6 Mar 2021 09:07:21 GMT Message-Id: <202103060907.12697LWC076689@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Toomas Soome Subject: git: 99e1b2d79868 - stable/13 - loader_4th: brand image is aligned right MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tsoome X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 99e1b2d79868eb8bad371b6d4d64fa1aab99fbc4 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 09:07:21 -0000 The branch stable/13 has been updated by tsoome: URL: https://cgit.FreeBSD.org/src/commit/?id=99e1b2d79868eb8bad371b6d4d64fa1aab99fbc4 commit 99e1b2d79868eb8bad371b6d4d64fa1aab99fbc4 Author: Toomas Soome AuthorDate: 2021-03-06 08:54:08 +0000 Commit: Toomas Soome CommitDate: 2021-03-06 09:06:51 +0000 loader_4th: brand image is aligned right With screen border removed, I forgot to update forth brand image coordinates to avoid image alignment. (cherry picked from commit 6a3095aa6d0350dda89bac66d26f22a01e2257c4) --- stand/forth/brand-fbsd.4th | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stand/forth/brand-fbsd.4th b/stand/forth/brand-fbsd.4th index b8e43e601c96..84245ef232b6 100644 --- a/stand/forth/brand-fbsd.4th +++ b/stand/forth/brand-fbsd.4th @@ -38,7 +38,7 @@ s" term-putimage" sfind if \ note, we use 0, 0 for image upper left as origin, \ and 0, 7 for lower right to preserve aspect ratio - >r 0 0 0 0 7 + >r 0 1 1 0 7 s" /boot/images/freebsd-brand-rev.png" r> execute if 2drop exit then else