From owner-svn-src-head@freebsd.org  Mon May  2 16:11:23 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63B07AEE6D4;
 Mon,  2 May 2016 16:11:23 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 185651F99;
 Mon,  2 May 2016 16:11:23 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.sbone.de (Postfix) with ESMTPS id 8885825D3A6D;
 Mon,  2 May 2016 16:11:19 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
 [IPv6:fde9:577b:c1a9:31::2013:2742])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPS id F3188D1F8BB;
 Mon,  2 May 2016 16:11:18 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
 by content-filter.sbone.de (content-filter.sbone.de
 [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
 with ESMTP id IfbckPiAoijI; Mon,  2 May 2016 16:11:17 +0000 (UTC)
Received: from [IPv6:fde9:577b:c1a9:4410:d97b:857d:5a4c:cb84] (unknown
 [IPv6:fde9:577b:c1a9:4410:d97b:857d:5a4c:cb84])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPSA id 5516FD1F8BA;
 Mon,  2 May 2016 16:11:16 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: svn commit: r298924 - head/usr.bin/sdiff
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
In-Reply-To: <CAG6CVpX2DTAGyRXyndki0y5ZGzjpEudBhn9i8xN7N98qMCwGSQ@mail.gmail.com>
Date: Mon, 2 May 2016 16:10:57 +0000
Cc: Benjamin Kaduk <bjkfbsd@gmail.com>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7DC09622-48D4-41C4-8913-9039D44BC1E7@FreeBSD.org>
References: <201605021507.u42F7hI3029685@repo.freebsd.org>
 <CAG6CVpUUNW-LN7F117yfH1-zZVVSoaxMULiLS6ApfD+inPSEFg@mail.gmail.com>
 <9AEBC481-D541-451F-82E0-7BCD571B0F93@FreeBSD.org>
 <CAJ5_RoAosXjNe9gmAquY9MPCUy-R4uCQD3XkSuDTBSGcoJ6Fcg@mail.gmail.com>
 <CAG6CVpX2DTAGyRXyndki0y5ZGzjpEudBhn9i8xN7N98qMCwGSQ@mail.gmail.com>
To: cem@FreeBSD.org
X-Mailer: Apple Mail (2.3112)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 May 2016 16:11:23 -0000


> On 02 May 2016, at 16:08 , Conrad Meyer <cem@FreeBSD.org> wrote:
>=20
> On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk <bjkfbsd@gmail.com> =
wrote:
>> On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb <bz@freebsd.org> =
wrote:
>>>> On 02 May 2016, at 15:32 , Conrad Meyer <cem@FreeBSD.org> wrote:
>>>>=20
>>>> Clang should really catch this too.  Why didn=E2=80=99t it?
>>>=20
>>> It was only powerpc;  sparc64 and mips were good as well.
>>=20
>> 'char' being signed vs. unsigned?
>=20
> Yeah, that occurred to me, but EOF should be out of range for any char
> type.  I'd like ((char)getchar() =3D=3D EOF) to warn on all platforms.

I think we just define EOF to be -1.  Someone should check, and that the =
warning message might be misleading.