From nobody Wed Jul 2 08:27:14 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bXCgQ6Rcyz604D3; Wed, 02 Jul 2025 08:27:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bXCgQ1GJJz3Z83; Wed, 02 Jul 2025 08:27:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751444834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ALTZr2IJJCg847SIugbTYjFrBb0urLLYwrOUhd4DGeo=; b=rsxsYXap2mqSq6EEhO5k4ZeQbEesZWTwMb3d9ciiQORMj6G+2r0jsQgwdLaPlLrCisdKFH mNVoht3u7Ihaj9A9SdLCYcbpDAAKqm1j0f2GJnLTQV4yPD0EeQSSrzBes95HDJkSTi4SMz f90Mbu0lp5MIvGlsolR6Kqz/pj+/BCfxBjplm/4xnAS9o3/rOICb+KxuUFF4b9Lj8s0Khn 5r+1hknygweo9klLlfXlFXgGtzYZJnWmlmszFMh1rdJ2nikki4AsdN08OlrkDeYT7dnB9f HNwhSYdi3CSTzkYjBsfVWA0fc5vtNSDUYOP1okSE5VbbxuA6+7A+izV6FD+Ihg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751444834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ALTZr2IJJCg847SIugbTYjFrBb0urLLYwrOUhd4DGeo=; b=K8LfPsFIYEWMbAZ73D8oMZniTZPGihted5eXKqyxCqo3lPpx73rD/uBS4t0CxOHIpFeCLw Cad/5/W8uVtow0HRs7OYqZ3taUdSs66Ta8VVUlTRC/2Om+ISCQjBWWTIwdSBXKbDLnZYcw DSmVjVh3pXyQzleD9Ao3BK5KaffMwjohBNsvfbq7LE0+osrkRzQ1CN4rg/Hw/VYr7zRA5x AM4+dewaiHXxvNpR5BjI1QnzcqMmo93Wts5UoDx3fzKHj8Je/R5PwA51EoOzuaaTzDz5N9 hj13fxzIhp+o4SMFwPGBBi2J6QeHlQ5ZirGeb2UyoAhohutpm6mRre46J3iCSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751444834; a=rsa-sha256; cv=none; b=jhpNa8NIKC2jApFsOOymmF594XopxNqGm4dk2pIyC3seqrGfTKFBGhBcS6khIv8bDsgxHo GegZhhVsT4z7FeKPYQWMnLUGMENsPla1QaE5T58sLLNF0UHSCPdeZN+4rh0OPMq7CJ8rTf RwPV4x4m5dm5LyNO85E1ATlz0EUKWJRumQb8FIRowxvwLmafkEe5p9RHlP+2LPL0DyvVx2 9AMxd9tsI/d/OFT4ZUDJDb66rzuWHg/Errrn+ThrJKsx33n+0oKraPAEs1D9c1XIOyvBdx vSHPxwfWVTxTxm933/7mc4T+HtnwBxjt38NPqIjRwQhLtG8ZxZUA24b2iL/qpg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bXCgQ0sj1z1B89; Wed, 02 Jul 2025 08:27:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5628REjq025584; Wed, 2 Jul 2025 08:27:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5628REVM025581; Wed, 2 Jul 2025 08:27:14 GMT (envelope-from git) Date: Wed, 2 Jul 2025 08:27:14 GMT Message-Id: <202507020827.5628REVM025581@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 35f70f6a33ff - main - pfctl: Remove wildcard address on loopack remnants List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 35f70f6a33ff9651974878ff9290dbb97d5f7888 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=35f70f6a33ff9651974878ff9290dbb97d5f7888 commit 35f70f6a33ff9651974878ff9290dbb97d5f7888 Author: Kristof Provost AuthorDate: 2025-06-27 12:40:21 +0000 Commit: Kristof Provost CommitDate: 2025-07-02 07:40:53 +0000 pfctl: Remove wildcard address on loopack remnants henning@ removed this functionality years ago, see the share/man/man4/lo.4 revision 1.27. OK jca claudio Obtained from: OpenBSD, kn , 436479f1d8 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/pfctl_parser.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/sbin/pfctl/pfctl_parser.c b/sbin/pfctl/pfctl_parser.c index 401404865986..871a18ca6c28 100644 --- a/sbin/pfctl/pfctl_parser.c +++ b/sbin/pfctl/pfctl_parser.c @@ -1756,15 +1756,8 @@ ifa_lookup(char *ifa_name, int flags) sizeof(struct pf_addr)); if (flags & PFI_AFLAG_NETWORK) set_ipmask(n, unmask(&p->addr.v.a.mask)); - else { - if (n->af == AF_INET && - p->ifa_flags & IFF_LOOPBACK && - p->ifa_flags & IFF_LINK1) - memcpy(&n->addr.v.a.mask, &p->addr.v.a.mask, - sizeof(struct pf_addr)); - else - set_ipmask(n, -1); - } + else + set_ipmask(n, -1); n->ifindex = p->ifindex; n->ifname = strdup(p->ifname);